Code review comment for lp:~kamstrup/unity/home-lenses

Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

> 237 (and other places): Instead of handling the gchar* yourself, use
> glib::String from UnityCore/GLibWrapper.h, it autofree's it when it's popped
> from the stack, so you don't need to worry about g_free in multiple places.

Ok, now using glib::String. It required that I add automatic std::string conversion to glib::String in order not to complicate the code - I was wondering if there was a specific reason it wasn't in glib::String already. Seems like a strange omission?

« Back to merge proposal