Code review comment for lp:~kampka/testtools/test-to-fixture

Hi Christian,

My apologies again about the delay. I'm a horrible person.

The fixture API in testtools is very closely aligned with the fixture API in lp:python-fixtures. TestCase implements the Fixture interface, and that's a deliberate thing. Fixtures have their own thing for using (i.e. depending on) other fixtures, which is great.

Just blatting the 'test' attribute is, imho, the wrong thing to do. I would prefer to see something in the Fixture API for setting the parent fixture. ("parent" for want of a better word.) This could be either an attribute or a method call.

On Monday, I'll chat with lifeless, the python-fixtures maintainer, to see what his thoughts are.

I know it's a pain to submit a patch, wait ages, think it's been forgotten only to have it receive a negative review. It's happened to me, and I am very sorry for being the person who has done it to someone else.

I genuinely appreciate your contributions to testtools and hope that this rough patch doesn't sour you to the whole project.

Thanks,
jml