Code review comment for lp:~kampka/testtools/test-to-fixture

Revision history for this message
Jonathan Lange (jml) wrote :

Ahh ok. Doing most of test set up with fixtures is a great idea, and I'm very glad they are working out so well for you. However, I'm not 100% convinced that you need to interact with your test from the fixture. Or, if it is needed, I'd like to know more about the use cases to make a more informed decision about the API.

Can you give me an example of the fail / skip case? That sounds like it might be something worth putting into testtools directly.

As for fixture analysis, what do you need to do that's not provided by the getDetails hook?

Sharing fixtures is great. I think Rob has a project planned for doing it in a clean, easy way. I wonder if this will convince him to write something up and let other folk with more spare hacking time get onto it. :)

« Back to merge proposal