Merge lp:~kamalmostafa/ubuntu/lucid/paraview/fix-522386-ftbfs into lp:ubuntu/lucid/paraview

Proposed by Kamal Mostafa
Status: Work in progress
Proposed branch: lp:~kamalmostafa/ubuntu/lucid/paraview/fix-522386-ftbfs
Merge into: lp:ubuntu/lucid/paraview
Diff against target: 55 lines (+13/-2)
4 files modified
Utilities/Xdmf2/libsrc/XdmfObject.h (+1/-0)
debian/changelog (+10/-0)
debian/control (+1/-1)
debian/rules (+1/-1)
To merge this branch: bzr merge lp:~kamalmostafa/ubuntu/lucid/paraview/fix-522386-ftbfs
Reviewer Review Type Date Requested Status
Kamal Mostafa (community) Disapprove
Fabrice Coutadeur Needs Fixing
Ubuntu branches Pending
Review via email: mp+19372@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Fabrice Coutadeur (fabricesp) wrote :

Hi,

Please add the change to Utilities/Xdmf2/libsrc/XdmfObject.h as a patch.

Thnaks,
Fabrice

review: Needs Fixing
Revision history for this message
Kamal Mostafa (kamalmostafa) wrote :

Oops! Thanks Fabrice -- new version on the way.

review: Disapprove

Unmerged revisions

11. By Kamal Mostafa

* Fix two problems which cause paraview FTBFS in Ubuntu Lucid: (LP: #522386)
  - Utilities/Xdmf2/libsrc/XdmfObject.h: add required #include <string.h>.
  - debian/rules, control: build with PARAVIEW_USE_SYSTEM_HDF5=OFF to use
    internal hdf5 library, as paraview requires an earlier version of
    libhdf5-serial-dev than Ubuntu Lucid's 1.8.3-2.1.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'Utilities/Xdmf2/libsrc/XdmfObject.h'
--- Utilities/Xdmf2/libsrc/XdmfObject.h 2008-10-17 17:47:41 +0000
+++ Utilities/Xdmf2/libsrc/XdmfObject.h 2010-02-19 23:45:27 +0000
@@ -69,6 +69,7 @@
69#ifndef __XdmfObject_h69#ifndef __XdmfObject_h
70#define __XdmfObject_h70#define __XdmfObject_h
7171
72#include <string.h> // strcmp, strlen, strcpy
7273
73# ifndef SWIG74# ifndef SWIG
74#if !defined( WIN32 ) || defined(__CYGWIN__)75#if !defined( WIN32 ) || defined(__CYGWIN__)
7576
=== modified file 'debian/changelog'
--- debian/changelog 2010-01-19 21:33:49 +0000
+++ debian/changelog 2010-02-19 23:45:27 +0000
@@ -1,3 +1,13 @@
1paraview (3.4.0-4ubuntu6) lucid; urgency=low
2
3 * Fix two problems which cause paraview FTBFS in Ubuntu Lucid: (LP: #522386)
4 - Utilities/Xdmf2/libsrc/XdmfObject.h: add required #include <string.h>.
5 - debian/rules, control: build with PARAVIEW_USE_SYSTEM_HDF5=OFF to use
6 internal hdf5 library, as paraview requires an earlier version of
7 libhdf5-serial-dev than Ubuntu Lucid's 1.8.3-2.1.
8
9 -- Kamal Mostafa <kamal@whence.com> Mon, 15 Feb 2010 13:39:50 -0800
10
1paraview (3.4.0-4ubuntu5) lucid; urgency=low11paraview (3.4.0-4ubuntu5) lucid; urgency=low
212
3 * rebuild for ffmpeg versioned symbols13 * rebuild for ffmpeg versioned symbols
414
=== modified file 'debian/control'
--- debian/control 2009-05-24 23:41:22 +0000
+++ debian/control 2010-02-19 23:45:27 +0000
@@ -4,7 +4,7 @@
4Maintainer: Ubuntu MOTU Developers <ubuntu-motu@lists.ubuntu.com>4Maintainer: Ubuntu MOTU Developers <ubuntu-motu@lists.ubuntu.com>
5XSBC-Original-Maintainer: Debian Scientific Computing Team <pkg-scicomp-devel@lists.alioth.debian.org>5XSBC-Original-Maintainer: Debian Scientific Computing Team <pkg-scicomp-devel@lists.alioth.debian.org>
6Uploaders: Christophe Prud'homme <prudhomm@debian.org>, Ondrej Certik <ondrej@certik.cz>6Uploaders: Christophe Prud'homme <prudhomm@debian.org>, Ondrej Certik <ondrej@certik.cz>
7Build-Depends: cdbs (>= 0.4.51), debhelper (>= 7), autotools-dev, quilt (>= 0.46-4), cmake (>= 2.4.8), libqt4-dev (>= 4.3.3-2), qt4-dev-tools, mpi-default-dev, libhdf5-serial-dev, libavformat-dev (>= 0.svn20080206), libavutil-dev, libavcodec-dev, libswscale-dev, python-dev, chrpath, libglu1-mesa-dev, libxt-dev, libxext-dev, doxygen, graphviz, gnuplot7Build-Depends: cdbs (>= 0.4.51), debhelper (>= 7), autotools-dev, quilt (>= 0.46-4), cmake (>= 2.4.8), libqt4-dev (>= 4.3.3-2), qt4-dev-tools, mpi-default-dev, libavformat-dev (>= 0.svn20080206), libavutil-dev, libavcodec-dev, libswscale-dev, python-dev, chrpath, libglu1-mesa-dev, libxt-dev, libxext-dev, doxygen, graphviz, gnuplot
8Standards-Version: 3.8.18Standards-Version: 3.8.1
9XS-DM-Upload-Allowed: yes9XS-DM-Upload-Allowed: yes
10Homepage: http://www.paraview.org/10Homepage: http://www.paraview.org/
1111
=== modified file 'debian/rules'
--- debian/rules 2009-06-10 12:26:28 +0000
+++ debian/rules 2010-02-19 23:45:27 +0000
@@ -32,7 +32,7 @@
32 -DVTK_USE_FFMPEG_ENCODER=ON \32 -DVTK_USE_FFMPEG_ENCODER=ON \
33 -DFFMPEG_INCLUDE_DIR=/usr/include/ffmpeg \33 -DFFMPEG_INCLUDE_DIR=/usr/include/ffmpeg \
34 -DPARAVIEW_USE_MPI=ON \34 -DPARAVIEW_USE_MPI=ON \
35 -DPARAVIEW_USE_SYSTEM_HDF5=ON \35 -DPARAVIEW_USE_SYSTEM_HDF5=OFF \
36 -DHDF5_ENABLE_PARALLEL=ON \36 -DHDF5_ENABLE_PARALLEL=ON \
37 -DPARAVIEW_ENABLE_PYTHON=ON \37 -DPARAVIEW_ENABLE_PYTHON=ON \
38 -DCMAKE_VERBOSE_MAKEFILE=OFF \38 -DCMAKE_VERBOSE_MAKEFILE=OFF \

Subscribers

People subscribed via source and target branches

to all changes: