Merge lp:~kamalmostafa/ubuntu/lucid/paraview/fix-522386-ftbfs into lp:ubuntu/lucid/paraview

Proposed by Kamal Mostafa
Status: Work in progress
Proposed branch: lp:~kamalmostafa/ubuntu/lucid/paraview/fix-522386-ftbfs
Merge into: lp:ubuntu/lucid/paraview
Diff against target: 55 lines (+13/-2)
4 files modified
Utilities/Xdmf2/libsrc/XdmfObject.h (+1/-0)
debian/changelog (+10/-0)
debian/control (+1/-1)
debian/rules (+1/-1)
To merge this branch: bzr merge lp:~kamalmostafa/ubuntu/lucid/paraview/fix-522386-ftbfs
Reviewer Review Type Date Requested Status
Kamal Mostafa (community) Disapprove
Fabrice Coutadeur Needs Fixing
Ubuntu branches Pending
Review via email: mp+19372@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Fabrice Coutadeur (fabricesp) wrote :

Hi,

Please add the change to Utilities/Xdmf2/libsrc/XdmfObject.h as a patch.

Thnaks,
Fabrice

review: Needs Fixing
Revision history for this message
Kamal Mostafa (kamalmostafa) wrote :

Oops! Thanks Fabrice -- new version on the way.

review: Disapprove

Unmerged revisions

11. By Kamal Mostafa

* Fix two problems which cause paraview FTBFS in Ubuntu Lucid: (LP: #522386)
  - Utilities/Xdmf2/libsrc/XdmfObject.h: add required #include <string.h>.
  - debian/rules, control: build with PARAVIEW_USE_SYSTEM_HDF5=OFF to use
    internal hdf5 library, as paraview requires an earlier version of
    libhdf5-serial-dev than Ubuntu Lucid's 1.8.3-2.1.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Utilities/Xdmf2/libsrc/XdmfObject.h'
2--- Utilities/Xdmf2/libsrc/XdmfObject.h 2008-10-17 17:47:41 +0000
3+++ Utilities/Xdmf2/libsrc/XdmfObject.h 2010-02-19 23:45:27 +0000
4@@ -69,6 +69,7 @@
5 #ifndef __XdmfObject_h
6 #define __XdmfObject_h
7
8+#include <string.h> // strcmp, strlen, strcpy
9
10 # ifndef SWIG
11 #if !defined( WIN32 ) || defined(__CYGWIN__)
12
13=== modified file 'debian/changelog'
14--- debian/changelog 2010-01-19 21:33:49 +0000
15+++ debian/changelog 2010-02-19 23:45:27 +0000
16@@ -1,3 +1,13 @@
17+paraview (3.4.0-4ubuntu6) lucid; urgency=low
18+
19+ * Fix two problems which cause paraview FTBFS in Ubuntu Lucid: (LP: #522386)
20+ - Utilities/Xdmf2/libsrc/XdmfObject.h: add required #include <string.h>.
21+ - debian/rules, control: build with PARAVIEW_USE_SYSTEM_HDF5=OFF to use
22+ internal hdf5 library, as paraview requires an earlier version of
23+ libhdf5-serial-dev than Ubuntu Lucid's 1.8.3-2.1.
24+
25+ -- Kamal Mostafa <kamal@whence.com> Mon, 15 Feb 2010 13:39:50 -0800
26+
27 paraview (3.4.0-4ubuntu5) lucid; urgency=low
28
29 * rebuild for ffmpeg versioned symbols
30
31=== modified file 'debian/control'
32--- debian/control 2009-05-24 23:41:22 +0000
33+++ debian/control 2010-02-19 23:45:27 +0000
34@@ -4,7 +4,7 @@
35 Maintainer: Ubuntu MOTU Developers <ubuntu-motu@lists.ubuntu.com>
36 XSBC-Original-Maintainer: Debian Scientific Computing Team <pkg-scicomp-devel@lists.alioth.debian.org>
37 Uploaders: Christophe Prud'homme <prudhomm@debian.org>, Ondrej Certik <ondrej@certik.cz>
38-Build-Depends: cdbs (>= 0.4.51), debhelper (>= 7), autotools-dev, quilt (>= 0.46-4), cmake (>= 2.4.8), libqt4-dev (>= 4.3.3-2), qt4-dev-tools, mpi-default-dev, libhdf5-serial-dev, libavformat-dev (>= 0.svn20080206), libavutil-dev, libavcodec-dev, libswscale-dev, python-dev, chrpath, libglu1-mesa-dev, libxt-dev, libxext-dev, doxygen, graphviz, gnuplot
39+Build-Depends: cdbs (>= 0.4.51), debhelper (>= 7), autotools-dev, quilt (>= 0.46-4), cmake (>= 2.4.8), libqt4-dev (>= 4.3.3-2), qt4-dev-tools, mpi-default-dev, libavformat-dev (>= 0.svn20080206), libavutil-dev, libavcodec-dev, libswscale-dev, python-dev, chrpath, libglu1-mesa-dev, libxt-dev, libxext-dev, doxygen, graphviz, gnuplot
40 Standards-Version: 3.8.1
41 XS-DM-Upload-Allowed: yes
42 Homepage: http://www.paraview.org/
43
44=== modified file 'debian/rules'
45--- debian/rules 2009-06-10 12:26:28 +0000
46+++ debian/rules 2010-02-19 23:45:27 +0000
47@@ -32,7 +32,7 @@
48 -DVTK_USE_FFMPEG_ENCODER=ON \
49 -DFFMPEG_INCLUDE_DIR=/usr/include/ffmpeg \
50 -DPARAVIEW_USE_MPI=ON \
51- -DPARAVIEW_USE_SYSTEM_HDF5=ON \
52+ -DPARAVIEW_USE_SYSTEM_HDF5=OFF \
53 -DHDF5_ENABLE_PARALLEL=ON \
54 -DPARAVIEW_ENABLE_PYTHON=ON \
55 -DCMAKE_VERBOSE_MAKEFILE=OFF \

Subscribers

People subscribed via source and target branches

to all changes: