Code review comment for lp:~kalon33/ubuntu/natty/pcsc-lite/merge-from-unstable

Revision history for this message
Nicolas DERIVE (kalon33) wrote :

@Colin: I think I figure out how to fix debian/control (I completely forgotten to remove remaining hal depends, sorry it's my first commit to Ubuntu and it's impressive to me).

For debian/changelog, do you want I merge both changelog from Debian and Ubuntu, or reusing Ubuntu one adding the new release ?

For debian/rules, I'm pretty new to that stuff, and I don't know how to pass configure options with new rules style, this is why I use the old one. Could you help me on this?

The last Debian/Ubuntu diff :

-Conflicts: libpcsclite-dev (<< ${binary:Version})
-Depends: ${shlibs:Depends}, ${misc:Depends}, pcscd (= ${binary:Version})
+Conflicts: libpcsclite-dev (<< ${binary:Version}), pcscd (<< ${binary:Version})
+Depends: ${shlibs:Depends}, ${misc:Depends}, pcscd

 is a mistake, I will fix it.

Thanks a lot.

« Back to merge proposal