Code review comment for lp:~kalon33/ubuntu/natty/pcsc-lite/merge-1.7.0-2-from-unstable

Revision history for this message
Nicolas DERIVE (kalon33) wrote :

> > @pitti: the libpcsclite1.install file is here, where should I change this?
>
> Same way as it was done before? The previous version did the moving in
> debian/rules:
>
> # move runtime libraries to /lib
> mv debian/libpcsclite1/usr/lib/libpcsclite.so.1* \
> debian/libpcsclite1/lib/
> rmdir -p --ignore-fail-on-non-empty debian/libpcsclite1/usr/lib
> ln -sf /lib/$$(readlink debian/libpcsclite-dev/usr/lib/libpcsclite.so)
> \
> debian/libpcsclite-dev/usr/lib/libpcsclite.so
>
> So you might just do the same in an override_dh_install rule?

I think it's done, what do you think?
>
> > For debian/rules: so there is no need to keep any change in our rules or I
> keep usbdrop, confdir and prefix?
>
> If debian doesn't explicitly specify --enable-confdir=/var/lib/pcscd, then
> this might just be the default value? Likewise, --enable-
> usbdropdir=/usr/lib/pcsc/drivers might be the default as well?

It seems that it was the case indeed.
>
> The rest is not necessary.
I dropped the rest.

Should I change other things?

Thanks for your help.

« Back to merge proposal