Merge lp:~kalikiana/ubuntu-ui-toolkit/tellMeAboutIt into lp:ubuntu-ui-toolkit

Proposed by Cris Dywan
Status: Merged
Approved by: Tim Peeters
Approved revision: 840
Merged at revision: 929
Proposed branch: lp:~kalikiana/ubuntu-ui-toolkit/tellMeAboutIt
Merge into: lp:ubuntu-ui-toolkit
Prerequisite: lp:~kalikiana/ubuntu-ui-toolkit/unit_x11_fixes
Diff against target: 76 lines (+20/-5)
5 files modified
modules/Ubuntu/Components/deployment.pri (+4/-1)
modules/Ubuntu/Layouts/deployment.pri (+4/-1)
modules/Ubuntu/Test/deployment.pri (+4/-1)
tests/unit/add_qmlmakecheck.pri (+4/-1)
tests/unit/runtest.sh (+4/-1)
To merge this branch: bzr merge lp:~kalikiana/ubuntu-ui-toolkit/tellMeAboutIt
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Tim Peeters Approve
Review via email: mp+199439@code.launchpad.net

Commit message

Suppress errors to work-around font error messages

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Gerry Boland (gerboland) wrote :

Shouldn't we have the Qt libs fixed to look for fonts in correct location?

Revision history for this message
Cris Dywan (kalikiana) wrote :

Yes. However as you may be aware this bug has been left unaddressed for months.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Tim Peeters (tpeeters) wrote :

okay

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'modules/Ubuntu/Components/deployment.pri'
--- modules/Ubuntu/Components/deployment.pri 2013-09-25 13:47:49 +0000
+++ modules/Ubuntu/Components/deployment.pri 2014-01-20 16:27:44 +0000
@@ -44,6 +44,9 @@
4444
45plugins_qmltypes.path = $$installPath45plugins_qmltypes.path = $$installPath
46plugins_qmltypes.files = plugins.qmltypes46plugins_qmltypes.files = plugins.qmltypes
47plugins_qmltypes.extra = $$[QT_INSTALL_BINS]/qmlplugindump -notrelocatable Ubuntu.Components 0.1 ../../ > $(INSTALL_ROOT)/$$installPath/plugins.qmltypes47# Silence spam on stderr due to fonts
48# https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1256999
49# https://bugreports.qt-project.org/browse/QTBUG-36243
50plugins_qmltypes.extra = $$[QT_INSTALL_BINS]/qmlplugindump -notrelocatable Ubuntu.Components 0.1 ../../ 2>/dev/null > $(INSTALL_ROOT)/$$installPath/plugins.qmltypes
4851
49INSTALLS += qmldir_file qml_files js_files artwork_files listitems_files listitems_artwork_files popups_files picker_files plugins_qmltypes52INSTALLS += qmldir_file qml_files js_files artwork_files listitems_files listitems_artwork_files popups_files picker_files plugins_qmltypes
5053
=== modified file 'modules/Ubuntu/Layouts/deployment.pri'
--- modules/Ubuntu/Layouts/deployment.pri 2013-12-09 16:26:24 +0000
+++ modules/Ubuntu/Layouts/deployment.pri 2014-01-20 16:27:44 +0000
@@ -13,6 +13,9 @@
1313
14plugins_qmltypes.path = $$installPath14plugins_qmltypes.path = $$installPath
15plugins_qmltypes.files = plugins.qmltypes15plugins_qmltypes.files = plugins.qmltypes
16plugins_qmltypes.extra = $$[QT_INSTALL_BINS]/qmlplugindump -notrelocatable Ubuntu.Layouts 0.1 ../../ > $(INSTALL_ROOT)/$$installPath/plugins.qmltypes16# Silence spam on stderr due to fonts
17# https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1256999
18# https://bugreports.qt-project.org/browse/QTBUG-36243
19plugins_qmltypes.extra = $$[QT_INSTALL_BINS]/qmlplugindump -notrelocatable Ubuntu.Layouts 0.1 ../../ 2>/dev/null > $(INSTALL_ROOT)/$$installPath/plugins.qmltypes
1720
18INSTALLS += qmldir_file plugins_qmltypes21INSTALLS += qmldir_file plugins_qmltypes
1922
=== modified file 'modules/Ubuntu/Test/deployment.pri'
--- modules/Ubuntu/Test/deployment.pri 2013-07-24 12:34:45 +0000
+++ modules/Ubuntu/Test/deployment.pri 2014-01-20 16:27:44 +0000
@@ -15,6 +15,9 @@
1515
16plugins_qmltypes.path = $$installPath16plugins_qmltypes.path = $$installPath
17plugins_qmltypes.files = plugins.qmltypes17plugins_qmltypes.files = plugins.qmltypes
18plugins_qmltypes.extra = $$[QT_INSTALL_BINS]/qmlplugindump -notrelocatable Ubuntu.Test 0.1 ../../ > $(INSTALL_ROOT)/$$installPath/plugins.qmltypes18# Silence spam on stderr due to fonts
19# https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1256999
20# https://bugreports.qt-project.org/browse/QTBUG-36243
21plugins_qmltypes.extra = $$[QT_INSTALL_BINS]/qmlplugindump -notrelocatable Ubuntu.Test 0.1 ../../ 2>/dev/null > $(INSTALL_ROOT)/$$installPath/plugins.qmltypes
1922
20INSTALLS += qmldir_file plugins_qmltypes23INSTALLS += qmldir_file plugins_qmltypes
2124
=== modified file 'tests/unit/add_qmlmakecheck.pri'
--- tests/unit/add_qmlmakecheck.pri 2013-12-13 15:50:35 +0000
+++ tests/unit/add_qmlmakecheck.pri 2014-01-20 16:27:44 +0000
@@ -8,7 +8,10 @@
8 check.commands += ../../unit/runtest.sh $${TARGET} $${TEST} minimal;8 check.commands += ../../unit/runtest.sh $${TARGET} $${TEST} minimal;
9}9}
10check.commands += cd ../../..;10check.commands += cd ../../..;
11check.commands += qmlplugindump Ubuntu.Components 0.1 modules > plugins.qmltypes;11# Silence spam on stderr due to fonts
12# https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1256999
13# https://bugreports.qt-project.org/browse/QTBUG-36243
14check.commands += qmlplugindump Ubuntu.Components 0.1 modules 2>/dev/null > plugins.qmltypes;
12# Palette gets included in Qt 5.2 qmlplugindump even though it's qml15# Palette gets included in Qt 5.2 qmlplugindump even though it's qml
13check.commands += BUILTINS=QQuick,QQml,U1db::,Palette python tests/qmlapicheck.py modules/Ubuntu/Components/qmldir modules/Ubuntu/Components/Colors/UbuntuColors.qml modules/Ubuntu/Components/*/qmldir plugins.qmltypes > components.api.new;16check.commands += BUILTINS=QQuick,QQml,U1db::,Palette python tests/qmlapicheck.py modules/Ubuntu/Components/qmldir modules/Ubuntu/Components/Colors/UbuntuColors.qml modules/Ubuntu/Components/*/qmldir plugins.qmltypes > components.api.new;
14check.commands += diff -Fqml -u components.api components.api.new || exit 1; cd tests/unit17check.commands += diff -Fqml -u components.api components.api.new || exit 1; cd tests/unit
1518
=== modified file 'tests/unit/runtest.sh'
--- tests/unit/runtest.sh 2013-12-09 14:02:08 +0000
+++ tests/unit/runtest.sh 2014-01-20 16:27:44 +0000
@@ -38,7 +38,10 @@
38function execute_test_cmd {38function execute_test_cmd {
39 echo "Executing $_CMD $_ARGS"39 echo "Executing $_CMD $_ARGS"
40 if [ $DISPLAY ]; then40 if [ $DISPLAY ]; then
41 QML2_IMPORT_PATH=../../../modules:$QML2_IMPORT_PATH UBUNTU_UI_TOOLKIT_THEMES_PATH=../../../modules $_CMD $_ARGS41 # https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1256999
42 # https://bugreports.qt-project.org/browse/QTBUG-36243
43 QML2_IMPORT_PATH=../../../modules:$QML2_IMPORT_PATH UBUNTU_UI_TOOLKIT_THEMES_PATH=../../../modules \
44 $_CMD $_ARGS 2>&1 | grep -v 'QFontDatabase: Cannot find font directory'
42 else45 else
43 echo "Skipped because no DISPLAY available"46 echo "Skipped because no DISPLAY available"
44 fi47 fi

Subscribers

People subscribed via source and target branches

to status/vote changes: