Merge lp:~kalikiana/ubuntu-ui-toolkit/tellMeAboutIt into lp:ubuntu-ui-toolkit
- tellMeAboutIt
- Merge into trunk
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Tim Peeters | ||||
Approved revision: | 840 | ||||
Merged at revision: | 929 | ||||
Proposed branch: | lp:~kalikiana/ubuntu-ui-toolkit/tellMeAboutIt | ||||
Merge into: | lp:ubuntu-ui-toolkit | ||||
Prerequisite: | lp:~kalikiana/ubuntu-ui-toolkit/unit_x11_fixes | ||||
Diff against target: |
76 lines (+20/-5) 5 files modified
modules/Ubuntu/Components/deployment.pri (+4/-1) modules/Ubuntu/Layouts/deployment.pri (+4/-1) modules/Ubuntu/Test/deployment.pri (+4/-1) tests/unit/add_qmlmakecheck.pri (+4/-1) tests/unit/runtest.sh (+4/-1) |
||||
To merge this branch: | bzr merge lp:~kalikiana/ubuntu-ui-toolkit/tellMeAboutIt | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot | continuous-integration | Approve | |
Tim Peeters | Approve | ||
Review via email:
|
Commit message
Suppress errors to work-around font error messages
Description of the change
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
PS Jenkins bot (ps-jenkins) wrote : | # |
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:836
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Gerry Boland (gerboland) wrote : | # |
Shouldn't we have the Qt libs fixed to look for fonts in correct location?
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Cris Dywan (kalikiana) wrote : | # |
Yes. However as you may be aware this bug has been left unaddressed for months.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:837
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:838
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:839
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Autolanding.
More details in the following jenkins job:
http://
Executed test runs:
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
deb: http://
FAILURE: http://
SUCCESS: http://
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:840
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Autolanding.
More details in the following jenkins job:
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
UNSTABLE: http://
UNSTABLE: http://
deb: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
PS Jenkins bot (ps-jenkins) : | # |
Preview Diff
1 | === modified file 'modules/Ubuntu/Components/deployment.pri' | |||
2 | --- modules/Ubuntu/Components/deployment.pri 2013-09-25 13:47:49 +0000 | |||
3 | +++ modules/Ubuntu/Components/deployment.pri 2014-01-20 16:27:44 +0000 | |||
4 | @@ -44,6 +44,9 @@ | |||
5 | 44 | 44 | ||
6 | 45 | plugins_qmltypes.path = $$installPath | 45 | plugins_qmltypes.path = $$installPath |
7 | 46 | plugins_qmltypes.files = plugins.qmltypes | 46 | plugins_qmltypes.files = plugins.qmltypes |
9 | 47 | plugins_qmltypes.extra = $$[QT_INSTALL_BINS]/qmlplugindump -notrelocatable Ubuntu.Components 0.1 ../../ > $(INSTALL_ROOT)/$$installPath/plugins.qmltypes | 47 | # Silence spam on stderr due to fonts |
10 | 48 | # https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1256999 | ||
11 | 49 | # https://bugreports.qt-project.org/browse/QTBUG-36243 | ||
12 | 50 | plugins_qmltypes.extra = $$[QT_INSTALL_BINS]/qmlplugindump -notrelocatable Ubuntu.Components 0.1 ../../ 2>/dev/null > $(INSTALL_ROOT)/$$installPath/plugins.qmltypes | ||
13 | 48 | 51 | ||
14 | 49 | INSTALLS += qmldir_file qml_files js_files artwork_files listitems_files listitems_artwork_files popups_files picker_files plugins_qmltypes | 52 | INSTALLS += qmldir_file qml_files js_files artwork_files listitems_files listitems_artwork_files popups_files picker_files plugins_qmltypes |
15 | 50 | 53 | ||
16 | === modified file 'modules/Ubuntu/Layouts/deployment.pri' | |||
17 | --- modules/Ubuntu/Layouts/deployment.pri 2013-12-09 16:26:24 +0000 | |||
18 | +++ modules/Ubuntu/Layouts/deployment.pri 2014-01-20 16:27:44 +0000 | |||
19 | @@ -13,6 +13,9 @@ | |||
20 | 13 | 13 | ||
21 | 14 | plugins_qmltypes.path = $$installPath | 14 | plugins_qmltypes.path = $$installPath |
22 | 15 | plugins_qmltypes.files = plugins.qmltypes | 15 | plugins_qmltypes.files = plugins.qmltypes |
24 | 16 | plugins_qmltypes.extra = $$[QT_INSTALL_BINS]/qmlplugindump -notrelocatable Ubuntu.Layouts 0.1 ../../ > $(INSTALL_ROOT)/$$installPath/plugins.qmltypes | 16 | # Silence spam on stderr due to fonts |
25 | 17 | # https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1256999 | ||
26 | 18 | # https://bugreports.qt-project.org/browse/QTBUG-36243 | ||
27 | 19 | plugins_qmltypes.extra = $$[QT_INSTALL_BINS]/qmlplugindump -notrelocatable Ubuntu.Layouts 0.1 ../../ 2>/dev/null > $(INSTALL_ROOT)/$$installPath/plugins.qmltypes | ||
28 | 17 | 20 | ||
29 | 18 | INSTALLS += qmldir_file plugins_qmltypes | 21 | INSTALLS += qmldir_file plugins_qmltypes |
30 | 19 | 22 | ||
31 | === modified file 'modules/Ubuntu/Test/deployment.pri' | |||
32 | --- modules/Ubuntu/Test/deployment.pri 2013-07-24 12:34:45 +0000 | |||
33 | +++ modules/Ubuntu/Test/deployment.pri 2014-01-20 16:27:44 +0000 | |||
34 | @@ -15,6 +15,9 @@ | |||
35 | 15 | 15 | ||
36 | 16 | plugins_qmltypes.path = $$installPath | 16 | plugins_qmltypes.path = $$installPath |
37 | 17 | plugins_qmltypes.files = plugins.qmltypes | 17 | plugins_qmltypes.files = plugins.qmltypes |
39 | 18 | plugins_qmltypes.extra = $$[QT_INSTALL_BINS]/qmlplugindump -notrelocatable Ubuntu.Test 0.1 ../../ > $(INSTALL_ROOT)/$$installPath/plugins.qmltypes | 18 | # Silence spam on stderr due to fonts |
40 | 19 | # https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1256999 | ||
41 | 20 | # https://bugreports.qt-project.org/browse/QTBUG-36243 | ||
42 | 21 | plugins_qmltypes.extra = $$[QT_INSTALL_BINS]/qmlplugindump -notrelocatable Ubuntu.Test 0.1 ../../ 2>/dev/null > $(INSTALL_ROOT)/$$installPath/plugins.qmltypes | ||
43 | 19 | 22 | ||
44 | 20 | INSTALLS += qmldir_file plugins_qmltypes | 23 | INSTALLS += qmldir_file plugins_qmltypes |
45 | 21 | 24 | ||
46 | === modified file 'tests/unit/add_qmlmakecheck.pri' | |||
47 | --- tests/unit/add_qmlmakecheck.pri 2013-12-13 15:50:35 +0000 | |||
48 | +++ tests/unit/add_qmlmakecheck.pri 2014-01-20 16:27:44 +0000 | |||
49 | @@ -8,7 +8,10 @@ | |||
50 | 8 | check.commands += ../../unit/runtest.sh $${TARGET} $${TEST} minimal; | 8 | check.commands += ../../unit/runtest.sh $${TARGET} $${TEST} minimal; |
51 | 9 | } | 9 | } |
52 | 10 | check.commands += cd ../../..; | 10 | check.commands += cd ../../..; |
54 | 11 | check.commands += qmlplugindump Ubuntu.Components 0.1 modules > plugins.qmltypes; | 11 | # Silence spam on stderr due to fonts |
55 | 12 | # https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1256999 | ||
56 | 13 | # https://bugreports.qt-project.org/browse/QTBUG-36243 | ||
57 | 14 | check.commands += qmlplugindump Ubuntu.Components 0.1 modules 2>/dev/null > plugins.qmltypes; | ||
58 | 12 | # Palette gets included in Qt 5.2 qmlplugindump even though it's qml | 15 | # Palette gets included in Qt 5.2 qmlplugindump even though it's qml |
59 | 13 | check.commands += BUILTINS=QQuick,QQml,U1db::,Palette python tests/qmlapicheck.py modules/Ubuntu/Components/qmldir modules/Ubuntu/Components/Colors/UbuntuColors.qml modules/Ubuntu/Components/*/qmldir plugins.qmltypes > components.api.new; | 16 | check.commands += BUILTINS=QQuick,QQml,U1db::,Palette python tests/qmlapicheck.py modules/Ubuntu/Components/qmldir modules/Ubuntu/Components/Colors/UbuntuColors.qml modules/Ubuntu/Components/*/qmldir plugins.qmltypes > components.api.new; |
60 | 14 | check.commands += diff -Fqml -u components.api components.api.new || exit 1; cd tests/unit | 17 | check.commands += diff -Fqml -u components.api components.api.new || exit 1; cd tests/unit |
61 | 15 | 18 | ||
62 | === modified file 'tests/unit/runtest.sh' | |||
63 | --- tests/unit/runtest.sh 2013-12-09 14:02:08 +0000 | |||
64 | +++ tests/unit/runtest.sh 2014-01-20 16:27:44 +0000 | |||
65 | @@ -38,7 +38,10 @@ | |||
66 | 38 | function execute_test_cmd { | 38 | function execute_test_cmd { |
67 | 39 | echo "Executing $_CMD $_ARGS" | 39 | echo "Executing $_CMD $_ARGS" |
68 | 40 | if [ $DISPLAY ]; then | 40 | if [ $DISPLAY ]; then |
70 | 41 | QML2_IMPORT_PATH=../../../modules:$QML2_IMPORT_PATH UBUNTU_UI_TOOLKIT_THEMES_PATH=../../../modules $_CMD $_ARGS | 41 | # https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1256999 |
71 | 42 | # https://bugreports.qt-project.org/browse/QTBUG-36243 | ||
72 | 43 | QML2_IMPORT_PATH=../../../modules:$QML2_IMPORT_PATH UBUNTU_UI_TOOLKIT_THEMES_PATH=../../../modules \ | ||
73 | 44 | $_CMD $_ARGS 2>&1 | grep -v 'QFontDatabase: Cannot find font directory' | ||
74 | 42 | else | 45 | else |
75 | 43 | echo "Skipped because no DISPLAY available" | 46 | echo "Skipped because no DISPLAY available" |
76 | 44 | fi | 47 | fi |
PASSED: Continuous integration, rev:835 jenkins. qa.ubuntu. com/job/ ubuntu- ui-toolkit- ci/1491/ jenkins. qa.ubuntu. com/job/ generic- mediumtests- trusty/ 1875 jenkins. qa.ubuntu. com/job/ generic- mediumtests- trusty- touch/1792 jenkins. qa.ubuntu. com/job/ ubuntu- ui-toolkit- trusty- amd64-ci/ 439 jenkins. qa.ubuntu. com/job/ ubuntu- ui-toolkit- trusty- armhf-ci/ 439 jenkins. qa.ubuntu. com/job/ ubuntu- ui-toolkit- trusty- armhf-ci/ 439/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ autopilot- testrunner- otto-trusty/ 1655 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- trusty- amd64/1875 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- trusty- amd64/1875/ artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- trusty- armhf/1792 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- trusty- armhf/1792/ artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ generic- mediumtests- runner- mako/4281 s-jenkins. ubuntu- ci:8080/ job/touch- flash-device/ 2540
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/ubuntu- ui-toolkit- ci/1491/ rebuild
http://