Ubuntu UI Toolkit

Code review comment for lp:~kalikiana/ubuntu-ui-toolkit/sortFilterModel

  1. sortFilterModel
  2. Merge into trunk
Revision history for this message
Tim Peeters (tpeeters) wrote :

141 + * Label {
142 + * text: {
143 + * var firstRow = sortedMovies.findFirst("title", /Elephant/))

isn't /Elephant/ supposed to be a string?

144 + * var sourceRow = sortedMovies.mapToSource(firstRow)
145 + * var foundTitle = movies.get(sourceRow).title
146 + * i18n.tr("First matching movie: %1").arg(foundTitle)

I would guess you want to keep foundTitle outside of the translateion.
i18n.tr() needs to be return i18n.tr();

add semicolons at the end of the lines

« Back to merge proposal