Code review comment for lp:~kalikiana/ubuntu-ui-toolkit/online

Revision history for this message
David Planella (dpm) wrote :

Ok, gotcha. The way the configuration works right now is the following:

online offline
  | |
  +---+----+
      |
    common

So both the online and offline config files include the common config, and you can switch between the two. The bug was not about changing the config files, but rather about the ubuntu-ui-toolkit-doc package to call the online conf during build instead of the offline one.

Although I agree it makes sense to improve the config if it can be in a better way.

After looking at it again, I understand that what the change is doing is the following:

offline
  |
  +-- online
        |
      common

If that works, then perfect :)

« Back to merge proposal