Merge lp:~kalikiana/ubuntu-ui-toolkit/cutedocs into lp:ubuntu-ui-toolkit

Proposed by Cris Dywan
Status: Merged
Approved by: Zsombor Egri
Approved revision: 812
Merged at revision: 845
Proposed branch: lp:~kalikiana/ubuntu-ui-toolkit/cutedocs
Merge into: lp:ubuntu-ui-toolkit
Diff against target: 68 lines (+22/-4)
3 files modified
debian/control (+12/-0)
documentation/ubuntu-ui-toolkit-online.qdocconf (+9/-0)
modules/Ubuntu/Components/Action.qml (+1/-4)
To merge this branch: bzr merge lp:~kalikiana/ubuntu-ui-toolkit/cutedocs
Reviewer Review Type Date Requested Status
Zsombor Egri Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+193280@code.launchpad.net

Commit message

Add dependencies and indexes to link Qt5 and Ubuntu.Unity.Action docs

Description of the change

Note: This is blocking on a non-gzipped .index file being shipped with unity-action-doc as addressed by lp:~kalikiana/unity-action-api/cutedocs.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:811
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/1128/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/212
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/206/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-trusty-amd64-ci/76
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-trusty-armhf-ci/76
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-trusty-armhf-ci/76/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/199
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/212
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/212/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/206
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/206/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/2827/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/2878/console
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/694
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/693

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/ubuntu-ui-toolkit-ci/1128/rebuild

review: Needs Fixing (continuous-integration)
812. By Cris Dywan

Add depenendencies and index to link to Ubuntu.Unity.Action docs

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Zsombor Egri (zsombi) wrote :

Looks nice, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/control'
--- debian/control 2013-11-06 04:17:28 +0000
+++ debian/control 2013-11-13 13:41:09 +0000
@@ -23,6 +23,12 @@
23 qtdeclarative5-qtfeedback-plugin,23 qtdeclarative5-qtfeedback-plugin,
24 qtdeclarative5-unity-action-plugin,24 qtdeclarative5-unity-action-plugin,
25 qtdeclarative5-localstorage-plugin,25 qtdeclarative5-localstorage-plugin,
26 qtdeclarative5-doc-html,
27 qtwebkit5-doc-html,
28 qtsvg5-doc-html,
29 qtscript5-doc-html,
30 qtmultimedia5-doc-html,
31 unity-action-doc,
26 devscripts,32 devscripts,
27 libqt5organizer5,33 libqt5organizer5,
28 qtpim5-dev,34 qtpim5-dev,
@@ -81,6 +87,12 @@
81Pre-Depends: dpkg (>= 1.15.6~), ${misc:Pre-Depends}87Pre-Depends: dpkg (>= 1.15.6~), ${misc:Pre-Depends}
82Depends: ${misc:Depends},88Depends: ${misc:Depends},
83 ${shlibs:Depends},89 ${shlibs:Depends},
90 qtdeclarative5-doc-html,
91 qtwebkit5-doc-html,
92 qtsvg5-doc-html,
93 qtscript5-doc-html,
94 qtmultimedia5-doc-html,
95 unity-action-doc,
84Conflicts: qt-components-ubuntu-doc96Conflicts: qt-components-ubuntu-doc
85Replaces: qt-components-ubuntu-doc97Replaces: qt-components-ubuntu-doc
86Provides: qt-components-ubuntu-doc98Provides: qt-components-ubuntu-doc
8799
=== modified file 'documentation/ubuntu-ui-toolkit-online.qdocconf'
--- documentation/ubuntu-ui-toolkit-online.qdocconf 2013-06-25 15:38:56 +0000
+++ documentation/ubuntu-ui-toolkit-online.qdocconf 2013-11-13 13:41:09 +0000
@@ -2,6 +2,15 @@
2include(ubuntu-appdev-site-header.qdocconf)2include(ubuntu-appdev-site-header.qdocconf)
3include(ubuntu-appdev-site-footer.qdocconf)3include(ubuntu-appdev-site-footer.qdocconf)
44
5indexes = \
6 /usr/share/qt5/doc/qtqml/qtqml.index \
7 /usr/share/qt5/doc/qtquick/qtquick.index \
8 /usr/share/qt5/doc/qtwebkit/qtwebkit.index \
9 /usr/share/qt5/doc/qtsvg/qtsvg.index \
10 /usr/share/qt5/doc/qtscript/qtscript.index \
11 /usr/share/qt5/doc/qtmultimedia/qtmultimedia.index \
12 /usr/share/doc/unity-action/qml/unity-action-qml-api.index \
13
5HTML.nobreadcrumbs = "false"14HTML.nobreadcrumbs = "false"
615
7HTML.headerstyles = \16HTML.headerstyles = \
817
=== modified file 'modules/Ubuntu/Components/Action.qml'
--- modules/Ubuntu/Components/Action.qml 2013-07-11 18:09:21 +0000
+++ modules/Ubuntu/Components/Action.qml 2013-11-13 13:41:09 +0000
@@ -27,13 +27,10 @@
2727
28 Examples: See \l Page28 Examples: See \l Page
29*/29*/
30
30UnityActions.Action {31UnityActions.Action {
31 id: action32 id: action
3233
33 // FIXME: the properties that are not defined here, but only documented using qmlproperty
34 // do not show up in the documentation. Best is to replace these docs by a reference
35 // to UnityActions.Action when they become available online.
36
37 /*!34 /*!
38 The title of the action.35 The title of the action.
39 \qmlproperty string Ubuntu.Components.Action::text36 \qmlproperty string Ubuntu.Components.Action::text

Subscribers

People subscribed via source and target branches

to status/vote changes: