Merge lp:~kalikiana/midori/wk2viewwarn into lp:midori

Proposed by Cris Dywan
Status: Merged
Approved by: André Stösel
Approved revision: 6307
Merged at revision: 6319
Proposed branch: lp:~kalikiana/midori/wk2viewwarn
Merge into: lp:midori
Diff against target: 45 lines (+4/-2)
1 file modified
midori/midori-view.c (+4/-2)
To merge this branch: bzr merge lp:~kalikiana/midori/wk2viewwarn
Reviewer Review Type Date Requested Status
André Stösel Approve
Review via email: mp+178355@code.launchpad.net

Commit message

Move #ifndef guards in Midori.View to fix warnings

To post a comment you must log in.
Revision history for this message
André Stösel (ivaldi) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'midori/midori-view.c'
--- midori/midori-view.c 2013-08-02 12:00:42 +0000
+++ midori/midori-view.c 2013-08-02 18:05:32 +0000
@@ -1296,8 +1296,8 @@
1296static void1296static void
1297midori_view_load_finished (MidoriView* view)1297midori_view_load_finished (MidoriView* view)
1298{1298{
1299 #ifndef HAVE_WEBKIT2
1300 midori_view_apply_scroll_position (view);1299 midori_view_apply_scroll_position (view);
1300 #ifndef HAVE_WEBKIT2
13011301
1302 {1302 {
1303 WebKitWebFrame* web_frame = webkit_web_view_get_main_frame (WEBKIT_WEB_VIEW (view->web_view));1303 WebKitWebFrame* web_frame = webkit_web_view_get_main_frame (WEBKIT_WEB_VIEW (view->web_view));
@@ -1488,6 +1488,7 @@
1488 g_object_notify (G_OBJECT (view), "title");1488 g_object_notify (G_OBJECT (view), "title");
1489}1489}
14901490
1491#ifndef HAVE_WEBKIT2
1491static void1492static void
1492webkit_web_view_statusbar_text_changed_cb (WebKitWebView* web_view,1493webkit_web_view_statusbar_text_changed_cb (WebKitWebView* web_view,
1493 const gchar* text,1494 const gchar* text,
@@ -1495,6 +1496,7 @@
1495{1496{
1496 midori_tab_set_statusbar_text (MIDORI_TAB (view), text);1497 midori_tab_set_statusbar_text (MIDORI_TAB (view), text);
1497}1498}
1499#endif
14981500
1499static gboolean1501static gboolean
1500midori_view_web_view_leave_notify_event_cb (WebKitWebView* web_view,1502midori_view_web_view_leave_notify_event_cb (WebKitWebView* web_view,
@@ -2569,6 +2571,7 @@
2569 return FALSE;2571 return FALSE;
2570}2572}
25712573
2574#ifndef HAVE_WEBKIT2
2572static gboolean2575static gboolean
2573webkit_web_view_web_view_ready_cb (GtkWidget* web_view,2576webkit_web_view_web_view_ready_cb (GtkWidget* web_view,
2574 MidoriView* view)2577 MidoriView* view)
@@ -2595,7 +2598,6 @@
2595 return TRUE;2598 return TRUE;
2596}2599}
25972600
2598#ifndef HAVE_WEBKIT2
2599static GtkWidget*2601static GtkWidget*
2600webkit_web_view_create_web_view_cb (GtkWidget* web_view,2602webkit_web_view_create_web_view_cb (GtkWidget* web_view,
2601 WebKitWebFrame* web_frame,2603 WebKitWebFrame* web_frame,

Subscribers

People subscribed via source and target branches

to all changes: