Merge lp:~kalikiana/midori/noSuccessWoFlags into lp:midori

Proposed by Cris Dywan
Status: Merged
Approved by: gue5t gue5t
Approved revision: 6832
Merged at revision: 6890
Proposed branch: lp:~kalikiana/midori/noSuccessWoFlags
Merge into: lp:midori
Diff against target: 29 lines (+11/-1)
1 file modified
midori/midori-view.c (+11/-1)
To merge this branch: bzr merge lp:~kalikiana/midori/noSuccessWoFlags
Reviewer Review Type Date Requested Status
gue5t gue5t Approve
Review via email: mp+241465@code.launchpad.net

This proposal supersedes a proposal from 2014-04-12.

Commit message

tls_flags from webkit_web_view_get_tls_info need to be 0

To post a comment you must log in.
Revision history for this message
gue5t gue5t (gue5t) wrote : Posted in a previous version of this proposal

r+ if you document what the return value of midori_view_get_tls_info means.

review: Needs Fixing
Revision history for this message
gue5t gue5t (gue5t) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'midori/midori-view.c'
2--- midori/midori-view.c 2014-07-30 17:47:30 +0000
3+++ midori/midori-view.c 2014-11-11 22:12:55 +0000
4@@ -479,6 +479,16 @@
5 }
6
7 #if defined (HAVE_LIBSOUP_2_29_91)
8+/**
9+ * midori_view_get_tls_info
10+ * @view: a #MidoriView
11+ * @request: a #WebKitNetworkRequest with WebKit1, otherwise %NULL
12+ * @tls_cert: variable to store the certificate
13+ * @tls_flags: variable to store the flags
14+ * @hostname: variable to store the hostname
15+ *
16+ * Returns %TRUE if the the host is secure and trustworthy.
17+ **/
18 gboolean
19 midori_view_get_tls_info (MidoriView* view,
20 void* request,
21@@ -492,7 +502,7 @@
22 gboolean success = webkit_web_view_get_tls_info (web_view, tls_cert, tls_flags);
23 if (*tls_cert != NULL)
24 g_object_ref (*tls_cert);
25- return success;
26+ return success && *tls_flags == 0;
27 #else
28 SoupMessage* message = midori_map_get_message (webkit_network_request_get_message (request));
29 if (message != NULL)

Subscribers

People subscribed via source and target branches

to all changes: