Merge lp:~kalikiana/midori/noSuccessWoFlags into lp:midori

Proposed by Cris Dywan
Status: Superseded
Proposed branch: lp:~kalikiana/midori/noSuccessWoFlags
Merge into: lp:midori
Diff against target: 29 lines (+11/-1)
1 file modified
midori/midori-view.c (+11/-1)
To merge this branch: bzr merge lp:~kalikiana/midori/noSuccessWoFlags
Reviewer Review Type Date Requested Status
gue5t gue5t Needs Fixing
Review via email: mp+215557@code.launchpad.net

This proposal has been superseded by a proposal from 2014-11-11.

Commit message

tls_flags from webkit_web_view_get_tls_info need to be 0

To post a comment you must log in.
6665. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6666. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6667. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6668. By axlrose112

Share 'youtube, vimeo, dailymotion' that you are playing in Midori using org.midori.mediaHerald

6669. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6670. By gue5t <email address hidden>

fix crash right-clicking forms on local pages

6671. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6672. By Cris Dywan

Never display about:new in the urlbar

6673. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6674. By gue5t <email address hidden>

Compile with valac 0.16 again

6675. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6676. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

Revision history for this message
gue5t gue5t (gue5t) wrote :

r+ if you document what the return value of midori_view_get_tls_info means.

review: Needs Fixing
6677. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6678. By gue5t <email address hidden>

Fix leaks of two references to the MidoriApp in Tabby

6679. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6680. By gue5t <email address hidden>

Don't focus the locationaction when leaving blank pages

6681. By Paweł Forysiuk

Add now playing extension to POTFILES

6682. By gue5t <email address hidden>

Fix a few simple leaks

6683. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6684. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6685. By gue5t <email address hidden>

Fix "open all in tabs" for bookmarks

6686. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6687. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6688. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6689. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6690. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6691. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6692. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6693. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6694. By gue5t <email address hidden>

Fix crash when activating the edit menu

6695. By Robert Roth

Show different messages based on network connectivity.

6696. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6697. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6698. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6699. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6700. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6701. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6702. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6703. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6704. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6705. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6706. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6707. By Robert Roth

This branch registers a handler to the network-changed signal of the GNetworkMonitor (which is already available, as midori already depends on GIO>=2.32.3, and GNetworkMonitor was introduced in 2.32), and in case a network is available (either connected to a network from an unconnected state, or switched to another network) reload all tabs from all browsers of midori.

6708. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6709. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6710. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6711. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6712. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6713. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6714. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6715. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6716. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6717. By Darcy Luís Neves Brás da Silva

Make middle clicking reload button duplicate the current tab, similar to other browsers

6718. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6719. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6720. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6721. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6722. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6723. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6724. By Cris Dywan

Allocate CookiePermissionManagerModalInfobar correctly

6725. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6726. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6727. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6728. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6729. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6730. By Paweł Forysiuk

Skip compiling webmedia extension on windows

6731. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6732. By axlrose112

Keep storing the last web media tab played.

6733. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6734. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6735. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6736. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6737. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6738. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6739. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6740. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6741. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6742. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6743. By Danielle Foré

Drop deprecated Granite LightWindow used for the Clear Private Data dialog

6744. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6745. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6746. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6747. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6748. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6749. By Paweł Forysiuk

Make adblock skip non-standard last update metadata strings

6750. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6751. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6752. By Paweł Forysiuk

makedist: Detect gstreamer api version, handle cert bundle being a symlinks, show images in gtk3 menus

6753. By gue5t <email address hidden>

Do not overescape page titles in view completion

6754. By gue5t <email address hidden>

Use correct signature for window-state-event handler

6755. By gue5t <email address hidden>

Fix some symbol names and transfer annotations in doc comments

6756. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6757. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6758. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6759. By André Auzi

bookmarks-db singleton was not completely connected to the application, as a result changes done in the panel were not properly propagated to the menu.

Additionnally import was not done in the database cache parent item, as a result the update of the root item, the dookmarks-db singleton, was not done.

Fix that.

6760. By Danielle Foré

don't hide window decorations for Midori-Granite

6761. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6762. By Robert Roth

Fix webkit2 downloads based on older branch

6763. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6764. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6765. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6766. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6767. By gue5t <email address hidden>

Fix crash when saving with associated resources

6768. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6769. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6770. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6771. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6772. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6773. By axlrose112

Disable Notify when extension is deactivated

6774. By Sam Hegarty

Show search menu upon left icon click in location bar

6775. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6776. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6777. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6778. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6779. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6780. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6781. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6782. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6783. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6784. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6785. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6786. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6787. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6788. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6789. By Chris Wallace <chris@aquarius>

Add "Add Bookmark" to menu

6790. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6791. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6792. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6793. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6794. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6795. By Dan

Set a placeholder text on the URL entry

6796. By meese

fixes tab history undo

6797. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6798. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6799. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6800. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6801. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6802. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6803. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6804. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6805. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6806. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6807. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6808. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6809. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6810. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6811. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6812. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6813. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6814. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6815. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6816. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6817. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6818. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6819. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6820. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6821. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6822. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6823. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6824. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6825. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6826. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6827. By Gero.Bare

Build-fix: Make PanedAction's Child.widget public

6828. By Gero.Bare

Remove dead code from browser and preferences

6829. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6830. By Launchpad Translations on behalf of midori

Launchpad automatic translations update.

6831. By Cris Dywan

Bump version to 0.5.9

6832. By Cris Dywan

tls_flags from webkit_web_view_get_tls_info need to be 0

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'midori/midori-view.c'
2--- midori/midori-view.c 2014-07-30 17:47:30 +0000
3+++ midori/midori-view.c 2014-11-11 22:11:45 +0000
4@@ -479,6 +479,16 @@
5 }
6
7 #if defined (HAVE_LIBSOUP_2_29_91)
8+/**
9+ * midori_view_get_tls_info
10+ * @view: a #MidoriView
11+ * @request: a #WebKitNetworkRequest with WebKit1, otherwise %NULL
12+ * @tls_cert: variable to store the certificate
13+ * @tls_flags: variable to store the flags
14+ * @hostname: variable to store the hostname
15+ *
16+ * Returns %TRUE if the the host is secure and trustworthy.
17+ **/
18 gboolean
19 midori_view_get_tls_info (MidoriView* view,
20 void* request,
21@@ -492,7 +502,7 @@
22 gboolean success = webkit_web_view_get_tls_info (web_view, tls_cert, tls_flags);
23 if (*tls_cert != NULL)
24 g_object_ref (*tls_cert);
25- return success;
26+ return success && *tls_flags == 0;
27 #else
28 SoupMessage* message = midori_map_get_message (webkit_network_request_get_message (request));
29 if (message != NULL)

Subscribers

People subscribed via source and target branches

to all changes: