Merge lp:~kalikiana/midori/largerdialog into lp:midori

Proposed by Cris Dywan
Status: Merged
Approved by: André Stösel
Approved revision: 6246
Merged at revision: 6304
Proposed branch: lp:~kalikiana/midori/largerdialog
Merge into: lp:midori
Diff against target: 38 lines (+7/-3)
2 files modified
data/about.css (+2/-2)
midori/midori-view.c (+5/-1)
To merge this branch: bzr merge lp:~kalikiana/midori/largerdialog
Reviewer Review Type Date Requested Status
André Stösel Approve
Review via email: mp+173346@code.launchpad.net

Commit message

Define large dialog icon size relative to dialog icon size

To post a comment you must log in.
Revision history for this message
Cris Dywan (kalikiana) wrote :

Would this be seen as a bug fix? Though I guess it's not super critical so we might also wait for after release.

Revision history for this message
André Stösel (ivaldi) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'data/about.css'
--- data/about.css 2013-06-29 22:38:04 +0000
+++ data/about.css 2013-07-07 08:02:26 +0000
@@ -19,7 +19,7 @@
19}19}
2020
21.indent {21.indent {
22 margin-left: 60px;22 margin-left: 5%;
23}23}
2424
25#main {25#main {
@@ -38,7 +38,7 @@
38}38}
3939
40#text {40#text {
41 margin-left: 80px;41 margin-left: 15%;
42}42}
4343
44h1 {44h1 {
4545
=== modified file 'midori/midori-view.c'
--- midori/midori-view.c 2013-07-01 20:20:33 +0000
+++ midori/midori-view.c 2013-07-07 08:02:26 +0000
@@ -886,7 +886,11 @@
886 static gint icon_size_large_dialog = 0;886 static gint icon_size_large_dialog = 0;
887887
888 if (!icon_size_large_dialog)888 if (!icon_size_large_dialog)
889 icon_size_large_dialog = gtk_icon_size_register ("large-dialog", 64, 64);889 {
890 gint width = 48, height = 48;
891 gtk_icon_size_lookup (GTK_ICON_SIZE_DIALOG, &width, &height);
892 icon_size_large_dialog = gtk_icon_size_register ("large-dialog", width * 2, height * 2);
893 }
890894
891 if (g_ascii_isalpha (icon_name[0]))895 if (g_ascii_isalpha (icon_name[0]))
892 {896 {

Subscribers

People subscribed via source and target branches

to all changes: