Code review comment for lp:~kalikiana/midori/folderzg

Revision history for this message
André Auzi (aauzi) wrote :

> I don't quite agree with that:
>
> I wanted to fix the assertion quickly, but I didn't want to block on
> researching how to get a path/to/folder, what format to use and delay the fix
> - ultimately it's possible and desirable to log folders in zeitgeist as well.
> I should've pointed that out to begin with.
>
> If a separator is passed most likely that's a bug in any relevant calling
> code. Maybe g_return_if_fail (KATZE_ITEM_IS_SEPARATOR (item)) instead?

sorry, I missed the ZEITGEIST_NFO_BOOKMARK_FOLDER existence.

g_return_if_fail (KATZE_ITEM_IS_SEPARATOR (item)) would be a plus.

I would then add a FIXME comment to trace the final intent.

« Back to merge proposal