Code review comment for lp:~kalikiana/midori/folderzg

Revision history for this message
Cris Dywan (kalikiana) wrote :

I don't quite agree with that:

I wanted to fix the assertion quickly, but I didn't want to block on researching how to get a path/to/folder, what format to use and delay the fix - ultimately it's possible and desirable to log folders in zeitgeist as well. I should've pointed that out to begin with.

If a separator is passed most likely that's a bug in any relevant calling code. Maybe g_return_if_fail (KATZE_ITEM_IS_SEPARATOR (item)) instead?

« Back to merge proposal