Code review comment for lp:~kalikiana/midori/folderzg

Revision history for this message
André Auzi (aauzi) wrote :

The remaining risk, if callers don't respect the contract:

 * midori_browser_update_history:
 * @item: a #KatzeItem
 * @type: "website", "bookmark" or "download"
 * @event: "access", "leave", "modify", "delete"

is that KatzeItems of other type are used. For the moment I only think about separators.

It may be more robust for future evolutions to code:

if (!KATZE_ITEM_IS_BOOKMARK (item))
    return;

review: Needs Fixing

« Back to merge proposal