Merge lp:~kalikiana/midori/fix1201130 into lp:midori

Proposed by Cris Dywan
Status: Merged
Approved by: Paweł Forysiuk
Approved revision: 6267
Merged at revision: 6267
Proposed branch: lp:~kalikiana/midori/fix1201130
Merge into: lp:midori
Diff against target: 55 lines (+12/-7)
1 file modified
midori/midori-browser.c (+12/-7)
To merge this branch: bzr merge lp:~kalikiana/midori/fix1201130
Reviewer Review Type Date Requested Status
gue5t gue5t Approve
Review via email: mp+174624@code.launchpad.net

Commit message

Consider where (tab/ window) for externally opening URLs

To post a comment you must log in.
Revision history for this message
gue5t gue5t (gue5t) wrote :

Looks good, works for me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'midori/midori-browser.c'
--- midori/midori-browser.c 2013-07-13 20:01:15 +0000
+++ midori/midori-browser.c 2013-07-14 17:10:31 +0000
@@ -1331,15 +1331,19 @@
1331}1331}
13321332
1333static bool1333static bool
1334midori_view_forward_external (GtkWidget* view,1334midori_view_forward_external (GtkWidget* view,
1335 const gchar* uri)1335 const gchar* uri,
1336 MidoriNewView where)
1336{1337{
1337 if (midori_paths_get_runtime_mode () == MIDORI_RUNTIME_MODE_APP)1338 if (midori_paths_get_runtime_mode () == MIDORI_RUNTIME_MODE_APP)
1338 return sokoke_show_uri (gtk_widget_get_screen (view), uri, 0, NULL);1339 return sokoke_show_uri (gtk_widget_get_screen (view), uri, 0, NULL);
1339 else if (midori_paths_get_runtime_mode () == MIDORI_RUNTIME_MODE_PRIVATE)1340 else if (midori_paths_get_runtime_mode () == MIDORI_RUNTIME_MODE_PRIVATE)
1340 {1341 {
1341 sokoke_spawn_app (uri, TRUE);1342 if (where == MIDORI_NEW_VIEW_WINDOW)
1342 return TRUE;1343 {
1344 sokoke_spawn_app (uri, TRUE);
1345 return TRUE;
1346 }
1343 }1347 }
1344 return FALSE;1348 return FALSE;
1345}1349}
@@ -1350,7 +1354,7 @@
1350 gboolean background,1354 gboolean background,
1351 MidoriBrowser* browser)1355 MidoriBrowser* browser)
1352{1356{
1353 if (midori_view_forward_external (view, uri))1357 if (midori_view_forward_external (view, uri, MIDORI_NEW_VIEW_TAB))
1354 return;1358 return;
13551359
1356 GtkWidget* new_view = midori_browser_add_uri (browser, uri);1360 GtkWidget* new_view = midori_browser_add_uri (browser, uri);
@@ -1367,7 +1371,7 @@
1367 const gchar* uri,1371 const gchar* uri,
1368 MidoriBrowser* browser)1372 MidoriBrowser* browser)
1369{1373{
1370 if (midori_view_forward_external (view, uri))1374 if (midori_view_forward_external (view, uri, MIDORI_NEW_VIEW_WINDOW))
1371 return;1375 return;
13721376
1373 MidoriBrowser* new_browser;1377 MidoriBrowser* new_browser;
@@ -1384,7 +1388,8 @@
1384 MidoriBrowser* browser)1388 MidoriBrowser* browser)
1385{1389{
1386 if (midori_view_forward_external (new_view,1390 if (midori_view_forward_external (new_view,
1387 katze_item_get_uri (midori_view_get_proxy_item (MIDORI_VIEW (new_view)))))1391 katze_item_get_uri (midori_view_get_proxy_item (MIDORI_VIEW (new_view))),
1392 where))
1388 return;1393 return;
13891394
1390 midori_browser_view_copy_history (new_view, view, TRUE);1395 midori_browser_view_copy_history (new_view, view, TRUE);

Subscribers

People subscribed via source and target branches

to all changes: