Code review comment for lp:~kalikiana/midori/externally

Revision history for this message
André Stösel (ivaldi) wrote :

The private mode part looks good and does work as I would expect, but the app mode part is kind of misleading.

If I'm using a none default profile, start some app and choose to open a link in a new window (in app mode), I woudln't expect midori do use my default profile to show this link.

Possible solutions:
 - detect which profiles are running and ask which one to use (especially when midori would start a new one)

PS: During testing there was a bug which causes midori to run the default profile twice, but I can't reproduce it -> I guess it was some kind of race condition in some lib

« Back to merge proposal