Merge lp:~kalikiana/midori/defaultzoom into lp:midori

Proposed by Cris Dywan
Status: Merged
Approved by: André Stösel
Approved revision: 6248
Merged at revision: 6248
Proposed branch: lp:~kalikiana/midori/defaultzoom
Merge into: lp:midori
Diff against target: 111 lines (+35/-1)
5 files modified
katze/katze-utils.c (+16/-0)
midori/midori-preferences.c (+6/-0)
midori/midori-settings.vala (+2/-0)
midori/midori-view.c (+3/-0)
midori/midori-websettings.c (+8/-1)
To merge this branch: bzr merge lp:~kalikiana/midori/defaultzoom
Reviewer Review Type Date Requested Status
André Stösel Approve
Review via email: mp+173351@code.launchpad.net

Commit message

Implement a default zoom level preference

To post a comment you must log in.
Revision history for this message
André Stösel (ivaldi) wrote :

What about [ctrl+0] (normal size)?
I'm not quite sure what to expect...

 - normal = 100%
 or
 - normal = default zoom

Revision history for this message
André Stösel (ivaldi) wrote :

We talked about this in IRC and came to the conclusion that [CTRL+0] should reset the zoom to 100%.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'katze/katze-utils.c'
--- katze/katze-utils.c 2013-04-16 23:16:24 +0000
+++ katze/katze-utils.c 2013-07-07 12:29:26 +0000
@@ -705,6 +705,22 @@
705 G_CALLBACK (proxy_widget_string_destroy_cb), object);705 G_CALLBACK (proxy_widget_string_destroy_cb), object);
706 g_free (notify_property);706 g_free (notify_property);
707 }707 }
708 else if (type == G_TYPE_PARAM_DOUBLE)
709 {
710 gdouble value;
711 g_object_get (object, property, &value, NULL);
712
713 widget = gtk_spin_button_new_with_range (
714 G_PARAM_SPEC_DOUBLE (pspec)->minimum,
715 G_PARAM_SPEC_DOUBLE (pspec)->maximum, 1);
716 /* Keep it narrow, 5 + 2 digits are usually fine */
717 gtk_entry_set_width_chars (GTK_ENTRY (widget), 5 + 2);
718 gtk_spin_button_set_digits (GTK_SPIN_BUTTON (widget), 2);
719 gtk_spin_button_set_value (GTK_SPIN_BUTTON (widget), value);
720 gtk_spin_button_set_increments (GTK_SPIN_BUTTON (widget), 0.1, -0.1);
721 g_signal_connect (widget, "value-changed",
722 G_CALLBACK (proxy_spin_button_changed_cb), object);
723 }
708 else if (type == G_TYPE_PARAM_FLOAT)724 else if (type == G_TYPE_PARAM_FLOAT)
709 {725 {
710 gfloat value;726 gfloat value;
711727
=== modified file 'midori/midori-preferences.c'
--- midori/midori-preferences.c 2013-06-26 21:54:50 +0000
+++ midori/midori-preferences.c 2013-07-07 12:29:26 +0000
@@ -403,6 +403,12 @@
403 gtk_button_set_label (GTK_BUTTON (button), _("Allow scripts to open popups"));403 gtk_button_set_label (GTK_BUTTON (button), _("Allow scripts to open popups"));
404 gtk_widget_set_tooltip_text (button, _("Whether scripts are allowed to open popup windows automatically"));404 gtk_widget_set_tooltip_text (button, _("Whether scripts are allowed to open popup windows automatically"));
405 SPANNED_ADD (button);405 SPANNED_ADD (button);
406 label = gtk_label_new (_("Default Zoom Level"));
407 gtk_misc_set_alignment (GTK_MISC (label), 0.0, 0.5);
408 INDENTED_ADD (label);
409 button = katze_property_proxy (settings, "zoom-level", NULL);
410 gtk_widget_set_tooltip_text (button, _("Initial factor to enlarge newly opened tabs by"));
411 SPANNED_ADD (button);
406412
407 FRAME_NEW (NULL);413 FRAME_NEW (NULL);
408 button = gtk_label_new (_("Preferred languages"));414 button = gtk_label_new (_("Preferred languages"));
409415
=== modified file 'midori/midori-settings.vala'
--- midori/midori-settings.vala 2013-04-11 20:33:43 +0000
+++ midori/midori-settings.vala 2013-07-07 12:29:26 +0000
@@ -119,6 +119,8 @@
119 /* Since: 0.1.4 */119 /* Since: 0.1.4 */
120 // [Deprecated (since = "0.4.7")]120 // [Deprecated (since = "0.4.7")]
121 public bool find_while_typing { get; set; default = false; }121 public bool find_while_typing { get; set; default = false; }
122 /* Since: 0.5.4 */
123 public double zoom_level { get; set; default = 1.0; }
122124
123 public bool open_popups_in_tabs { get; set; default = true; }125 public bool open_popups_in_tabs { get; set; default = true; }
124 /* Since: 0.2.0 */126 /* Since: 0.2.0 */
125127
=== modified file 'midori/midori-view.c'
--- midori/midori-view.c 2013-07-01 20:20:33 +0000
+++ midori/midori-view.c 2013-07-07 12:29:26 +0000
@@ -3280,6 +3280,7 @@
3280 MidoriWebSettings* settings)3280 MidoriWebSettings* settings)
3281{3281{
3282 gboolean zoom_text_and_images;3282 gboolean zoom_text_and_images;
3283 gdouble zoom_level;
32833284
3284 if (view->settings)3285 if (view->settings)
3285 g_signal_handlers_disconnect_by_func (view->settings,3286 g_signal_handlers_disconnect_by_func (view->settings,
@@ -3294,6 +3295,7 @@
3294 G_CALLBACK (midori_view_settings_notify_cb), view);3295 G_CALLBACK (midori_view_settings_notify_cb), view);
32953296
3296 g_object_get (view->settings,3297 g_object_get (view->settings,
3298 "zoom-level", &zoom_level,
3297 "zoom-text-and-images", &zoom_text_and_images,3299 "zoom-text-and-images", &zoom_text_and_images,
3298 "close-buttons-on-tabs", &view->close_buttons_on_tabs,3300 "close-buttons-on-tabs", &view->close_buttons_on_tabs,
3299 "open-new-pages-in", &view->open_new_pages_in,3301 "open-new-pages-in", &view->open_new_pages_in,
@@ -3305,6 +3307,7 @@
3305 webkit_web_view_set_full_content_zoom (WEBKIT_WEB_VIEW (view->web_view),3307 webkit_web_view_set_full_content_zoom (WEBKIT_WEB_VIEW (view->web_view),
3306 zoom_text_and_images);3308 zoom_text_and_images);
3307 #endif3309 #endif
3310 midori_view_set_zoom_level (view, zoom_level);
3308}3311}
33093312
3310/**3313/**
33113314
=== modified file 'midori/midori-websettings.c'
--- midori/midori-websettings.c 2013-06-19 20:20:05 +0000
+++ midori/midori-websettings.c 2013-07-07 12:29:26 +0000
@@ -1395,7 +1395,7 @@
1395 integer = g_key_file_get_integer (key_file, "settings", property, NULL);1395 integer = g_key_file_get_integer (key_file, "settings", property, NULL);
1396 g_object_set (settings, property, integer, NULL);1396 g_object_set (settings, property, integer, NULL);
1397 }1397 }
1398 else if (type == G_TYPE_PARAM_FLOAT)1398 else if (type == G_TYPE_PARAM_FLOAT || type == G_TYPE_PARAM_DOUBLE)
1399 {1399 {
1400 number = g_key_file_get_double (key_file, "settings", property, NULL);1400 number = g_key_file_get_double (key_file, "settings", property, NULL);
1401 g_object_set (settings, property, number, NULL);1401 g_object_set (settings, property, number, NULL);
@@ -1504,6 +1504,13 @@
1504 if (integer != G_PARAM_SPEC_UINT (pspec)->default_value)1504 if (integer != G_PARAM_SPEC_UINT (pspec)->default_value)
1505 g_key_file_set_integer (key_file, "settings", property, integer);1505 g_key_file_set_integer (key_file, "settings", property, integer);
1506 }1506 }
1507 else if (type == G_TYPE_PARAM_DOUBLE)
1508 {
1509 gdouble number;
1510 g_object_get (settings, property, &number, NULL);
1511 if (number != G_PARAM_SPEC_DOUBLE (pspec)->default_value)
1512 g_key_file_set_double (key_file, "settings", property, number);
1513 }
1507 else if (type == G_TYPE_PARAM_FLOAT)1514 else if (type == G_TYPE_PARAM_FLOAT)
1508 {1515 {
1509 gfloat number;1516 gfloat number;

Subscribers

People subscribed via source and target branches

to all changes: