Code review comment for lp:~kalikiana/midori/alwaysnotify

Revision history for this message
Cris Dywan (kalikiana) wrote :

> It's also sane for non-Windows systems to not have libnotify installed

I'm very doubtful here. All DEs roughly following freedesktop.org use notifications. It's also been proposed for inclusion with GTK+ which by itself says something.

> …libnotify does not provide essential functionality…

I disagree with this assumption and others voiced concerns that for example "launcher created" may not show up without libnotify. It is expected in the typical case, except custom kiosk setups and the like which may intentionally block the notification daemon.

I'll file a bug to re-consider the Windows case. I simply didn't want to block on it.

« Back to merge proposal