Code review comment for lp:~kalikiana/midori/alwaysnotify

Revision history for this message
gue5t gue5t (gue5t) wrote :

In my opinion it's perfectly sane for users to want some programs to not produce notifications. It's also sane for non-Windows systems to not have libnotify installed, and given that libnotify does not provide essential functionality I don't see why it should be made a hard-dependency. However, I do agree that ./configure is not the right place for users to configure whether on typical desktop systems whether they would like to see notifications from Midori. We should instead have a preference to control notifications.

Removing code that manually calls notify-send is a very good thing. Executing random system binaries is awful and Midori built on a system which wants notification features should depend on the requisite software, i.e. libnotify.

review: Needs Fixing

« Back to merge proposal