Code review comment for lp:~kalebral-deactivatedaccount/drizzle-automation/report-sqlbench
Revision history for this message
| Lee Bieber (kalebral-deactivatedaccount) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
a60fb26
(Get the code!)
Hi Jay
For #1 I wanted to pass "None" so that I could reuse the existing function and not have to duplicate a lot of code. When the report sees "None" is just prints "N/A" in the output. I was trying to avoid lots of duplication of code. Should I be passing something else?
For #2 I had pulled out the function from reports/sysbench.py so that everyone can use this function. Do you still want me to put it in a separate file?