Drizzle Automation

Merge lp:~kalebral-deactivatedaccount/drizzle-automation/fix-lcov into lp:drizzle-automation

  1. fix-lcov
  2. Merge into trunk
Proposed by Lee Bieber
Status: Merged
Merged at revision: not available
Proposed branch: lp:~kalebral-deactivatedaccount/drizzle-automation/fix-lcov
Merge into: lp:drizzle-automation
Diff against target: None lines
To merge this branch: bzr merge lp:~kalebral-deactivatedaccount/drizzle-automation/fix-lcov
Reviewer Review Type Date Requested Status
Jay Pipes Approve
Review via email: mp+7591@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Lee Bieber (kalebral-deactivatedaccount) wrote :

fix problem when inserting data into database, was not zeroing out the sql string as we process each directory

Revision history for this message
Jay Pipes (jaypipes) wrote :

Excellent catch. Approved and will merge in shortly.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lcov/run.py'
--- lcov/run.py 2009-06-10 23:02:49 +0000
+++ lcov/run.py 2009-06-17 21:25:46 +0000
@@ -207,8 +207,8 @@
207 percentages[dir]= 0.0207 percentages[dir]= 0.0
208208
209 # Insert into the DB...209 # Insert into the DB...
210 sql= ""
211 for dir in lcov_dirs:210 for dir in lcov_dirs:
211 sql= ""
212 logging.info("%s %s %s %s %0.2f " % (server_name, server_version, dir, run_date, percentages[dir]))212 logging.info("%s %s %s %s %0.2f " % (server_name, server_version, dir, run_date, percentages[dir]))
213 sql= sql + """213 sql= sql + """
214 INSERT INTO lcov_stats (server, version, dir_name, run_date, coverage_percent) VALUES ('%s','%s','%s','%s', %0.2f); """ % (server_name, server_version, dir, run_date, percentages[dir])214 INSERT INTO lcov_stats (server, version, dir_name, run_date, coverage_percent) VALUES ('%s','%s','%s','%s', %0.2f); """ % (server_name, server_version, dir, run_date, percentages[dir])

Subscribers

People subscribed via source and target branches

to all changes: