Ubuntu
gce-compute-image-packages package

Code review comment for ~kajiya/ubuntu/+source/gce-compute-image-packages:change-udev-rules-for-HDDs-noble-devel

  1. Git
  2. lp:~kajiya/ubuntu/+source/gce-compute-image-packages
  3. change-udev-rules-for-HDDs-noble-devel
  4. Merge into ubuntu/noble-devel
Revision history for this message
Utkarsh Gupta (utkarsh) wrote :

Hey! Thanks for putting this up, few things that I worked out before sponsoring this:

- This MP is submitted against the wrong git repository. :)
  The right one is - https://code.launchpad.net/~cloud-images/cloud-images/+git/gce-compute-image-packages.

- debian/changelog entry doesn't reference the LP bug. Not a big deal but it really should. :)

- The versioning is incorrect. `~24.04.0` is not needed here as noble is a devel release atm. ~/tilde is used when we need to backport stuff. But since this isn't an SRU but a devel upload, we just increment the number by 1. So -0ubuntu2 is the way to go.

- The bug has the SRU template but it has two "impact" and "test plan". We should fix that to only have 1 each. :)
  But this isn't a blocker for this upload as this isn't an SRU upload but a devel one.

I've fixed all of these changes and sponsored the upload. That said, I'm disapproving the upload here because this is the wrong git repository and I've pushed your cherry-picked commits to the right one. ;)

review: Disapprove
Reply

« Back to merge proposal