Merge lp:~kaijanmaki/unity-action-api/fix_nohud_build into lp:~unity-team/unity-action-api/nohud

Proposed by Antti Kaijanmäki
Status: Merged
Approved by: Antti Kaijanmäki
Approved revision: 30
Merged at revision: 22
Proposed branch: lp:~kaijanmaki/unity-action-api/fix_nohud_build
Merge into: lp:~unity-team/unity-action-api/nohud
Diff against target: 90 lines (+20/-2)
5 files modified
CMakeLists.txt (+7/-2)
debian/control (+1/-0)
src/CMakeLists.txt (+5/-0)
src/unity-action-manager.cpp (+4/-0)
test/cpp/tst_actionmanager.cpp (+3/-0)
To merge this branch: bzr merge lp:~kaijanmaki/unity-action-api/fix_nohud_build
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Unity Team Pending
Review via email: mp+173736@code.launchpad.net

Commit message

* If we don't have libhud, we need to manually add the gio headers and libraries.
* add libglib2.0-dev to build-deps
* other random boring backporting related changes

To post a comment you must log in.
23. By Antti Kaijanmäki

If we don't have libhud, we need to manually add the gio headers and libraries.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
24. By Antti Kaijanmäki

lower the minimum required cmake

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
25. By Antti Kaijanmäki

g_type_init() for older glib and require cmake 2.8.9 after all.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
26. By Antti Kaijanmäki

Don't compile with -std=c++11

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
27. By Antti Kaijanmäki

try with --std=c++0x instead

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
28. By Antti Kaijanmäki

be permissive.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
29. By Antti Kaijanmäki

buggy cmake,qt5..

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
30. By Antti Kaijanmäki

...

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'CMakeLists.txt'
--- CMakeLists.txt 2013-07-09 12:52:13 +0000
+++ CMakeLists.txt 2013-07-09 20:39:24 +0000
@@ -19,9 +19,13 @@
19pkg_search_module(HUD hud-2)19pkg_search_module(HUD hud-2)
20if(${HUD_FOUND})20if(${HUD_FOUND})
21 add_definitions( -DHAVE_HUD=1 )21 add_definitions( -DHAVE_HUD=1 )
22else()
23pkg_check_modules(GLIB2 REQUIRED glib-2.0)
24pkg_check_modules(GOBJECT2 REQUIRED gobject-2.0)
25pkg_check_modules(GIO2 REQUIRED gio-2.0)
22endif()26endif()
2327
24set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} --std=c++11 -fno-permissive -pedantic -Wall -Wextra")28set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} --std=c++0x -fpermissive -pedantic -Wall -Wextra")
25set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fvisibility=hidden")29set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fvisibility=hidden")
2630
27if ("${CMAKE_BUILD_TYPE}" STREQUAL "release" OR "${CMAKE_BUILD_TYPE}" STREQUAL "relwithdebinfo")31if ("${CMAKE_BUILD_TYPE}" STREQUAL "release" OR "${CMAKE_BUILD_TYPE}" STREQUAL "relwithdebinfo")
@@ -61,12 +65,13 @@
61add_custom_target(cppcheck COMMAND cppcheck --enable=all -q --error-exitcode=265add_custom_target(cppcheck COMMAND cppcheck --enable=all -q --error-exitcode=2
62 ${CMAKE_SOURCE_DIR}/src ${CMAKE_SOURCE_DIR}/tests)66 ${CMAKE_SOURCE_DIR}/src ${CMAKE_SOURCE_DIR}/tests)
63find_package(Qt5Quick REQUIRED)67find_package(Qt5Quick REQUIRED)
68include_directories(${Qt5Quick_INCLUDE_DIRS})
6469
65include_directories(include)70include_directories(include)
66add_subdirectory(src)71add_subdirectory(src)
67add_subdirectory(qml)72add_subdirectory(qml)
68add_subdirectory(documentation)73add_subdirectory(documentation)
69add_subdirectory(examples)74#add_subdirectory(examples)
7075
71find_program(qmltestrunner_exe qmltestrunner)76find_program(qmltestrunner_exe qmltestrunner)
7277
7378
=== modified file 'debian/control'
--- debian/control 2013-07-09 12:52:13 +0000
+++ debian/control 2013-07-09 20:39:24 +0000
@@ -15,6 +15,7 @@
15 qtdeclarative5-dev-tools,15 qtdeclarative5-dev-tools,
16 qtdeclarative5-qtquick2-plugin,16 qtdeclarative5-qtquick2-plugin,
17 qtdeclarative5-test-plugin,17 qtdeclarative5-test-plugin,
18 libglib2.0-dev,
18 dbus-test-runner19 dbus-test-runner
19Standards-Version: 3.9.220Standards-Version: 3.9.2
20Homepage: https://launchpad.net/unity-action-api21Homepage: https://launchpad.net/unity-action-api
2122
=== modified file 'src/CMakeLists.txt'
--- src/CMakeLists.txt 2013-07-09 12:52:13 +0000
+++ src/CMakeLists.txt 2013-07-09 20:39:24 +0000
@@ -35,6 +35,11 @@
35if(${HUD_FOUND})35if(${HUD_FOUND})
36 include_directories(${HUD_INCLUDE_DIRS})36 include_directories(${HUD_INCLUDE_DIRS})
37 target_link_libraries (unity-action-qt ${HUD_LIBRARIES})37 target_link_libraries (unity-action-qt ${HUD_LIBRARIES})
38else()
39 include_directories(${GLIB2_INCLUDE_DIRS})
40 include_directories(${GOBJECT2_INCLUDE_DIRS})
41 include_directories(${GIO2_INCLUDE_DIRS})
42 target_link_libraries (unity-action-qt ${GLIB2_LIBRARIES} ${GOBJECT2_LIBRARIES} ${GIO2_LIBRARIES})
38endif()43endif()
3944
40qt5_use_modules(unity-action-qt Core)45qt5_use_modules(unity-action-qt Core)
4146
=== modified file 'src/unity-action-manager.cpp'
--- src/unity-action-manager.cpp 2013-07-09 12:52:13 +0000
+++ src/unity-action-manager.cpp 2013-07-09 20:39:24 +0000
@@ -294,6 +294,10 @@
294 : QObject(parent),294 : QObject(parent),
295 d(new Private(this))295 d(new Private(this))
296{296{
297#ifndef GLIB_VERSION_2_36
298 g_type_init ();
299#endif
300
297 d->activeLocalContext = 0;301 d->activeLocalContext = 0;
298 /*! \todo document me */302 /*! \todo document me */
299#ifdef HAVE_HUD303#ifdef HAVE_HUD
300304
=== modified file 'test/cpp/tst_actionmanager.cpp'
--- test/cpp/tst_actionmanager.cpp 2013-07-01 23:12:06 +0000
+++ test/cpp/tst_actionmanager.cpp 2013-07-09 20:39:24 +0000
@@ -35,6 +35,9 @@
35TestActionManager::initTestCase()35TestActionManager::initTestCase()
36{36{
37 manager = new ActionManager(this);37 manager = new ActionManager(this);
38#ifndef GLIB_VERSION_2_36
39 g_type_init ();
40#endif
38 dbusc = g_bus_get_sync(G_BUS_TYPE_SESSION, NULL, NULL);41 dbusc = g_bus_get_sync(G_BUS_TYPE_SESSION, NULL, NULL);
39 action_group = g_dbus_action_group_get(dbusc,42 action_group = g_dbus_action_group_get(dbusc,
40 g_dbus_connection_get_unique_name(dbusc),43 g_dbus_connection_get_unique_name(dbusc),

Subscribers

People subscribed via source and target branches

to all changes: