Code review comment for lp:~kaihengfeng/unity-settings-daemon/add-brightness-limit-mechanism

Revision history for this message
Martin Pitt (pitti) wrote :

TBH, I'm not a fan of introducing configurability for such things. It sounds too much like an "unbreak my desktop setting" and a hack for a bug, it introduces combinatorial explosion again which nobody will test properly, and it'll be hard to drop such settings again.

My opinion is not authoritative here of course, it's ultimately the desktop teams' decision.

review: Disapprove

« Back to merge proposal