Code review comment for lp:~kai-mast/friends/keep-mentions

Revision history for this message
Robert Bruce Park (robru) wrote :

Hi Kai, I have a couple concerns about this branch:

* I'd like to see the 'counts' dict be a defaultdict. Then you save having to check whether the stream is already present or not.

* I see a lot of deletions from the testsuite and no additions. Any way you can flesh out the tests to cover the new behavior?

« Back to merge proposal