Code review comment for lp:~kai-mast/friends/fetch-twitter-images

Revision history for this message
Kai Mast (kai-mast) wrote :

@Adolfo: yes that is exactly what I thought

Robert, if I don't use the args dictionary I woudl have to add link_picture='' to some of the tests. That was in my eyes a worse than adding the dictionary, but if you prefer that I will do so.

What I mean with the other post was the following: The t.co link is currently replaced with the long link instead of the pretty display link. The easiest way to solve this would be to directly insert an html tag at line 37.
But there seems to be some processing at a higer level that replaces links by HTML tags, so I don't know it if this would break in such a case...

« Back to merge proposal