Code review comment for lp:~kai-mast/friends/fetch-twitter-images

Revision history for this message
Robert Bruce Park (robru) wrote :

Please specify a default value for picture because python's None value i don't think will work. So:

  picture = url.get('media_url', '')

Oh and please add a test for this as well (look at the existing tests, you might have to add some extra json if there isn't already a media_url key present in the example data).

« Back to merge proposal