Code review comment for lp:~kai-mast/friends-app/new-postview
Revision history for this message
| Kai Mast (kai-mast) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
You were right Ken!
So the Feed is a page now and we push the Tabs directly on the PageStack (was wrapped in a Page before). This resolved the clipping issue.
One small problem is left: When you jump to the top the header reappears and you are not completely at the top. There is no way to fix this right now. We need a way to reveal the header first and then jump to the top which is not possible right now.
But I think it looks really good now and is mergeable.