Code review comment for lp:~kai-mast/friends-app/new-postview

Revision history for this message
Robert Bruce Park (robru) wrote :

Sorry for the delay in reviewing, been a bit busy with other projects!

It looks really good now! The scrolling and margin errors I previously mentioned are fixed. There is however one new issue that I didn't notice before: The top Tab header is overlapping the page content poorly. I remember seeing this issue before a long time ago, but this time it's affecting the main timeline view:

http://imgur.com/u6IEdxu

I confirmed that this is happening only in your branch, trunk does not exhibit this behavior. In trunk the header is always visible and always opaque, but in your branch the header scrolls away with the page content fine, but then when you scroll it back into view, the feed is visible behind it.

review: Needs Fixing

« Back to merge proposal