Code review comment for lp:~kaaveeacs/drizzle/privatized-members-of-NestedJoin

On Fri, Apr 15, 2011 at 8:42 PM, Monty Taylor <email address hidden> wrote:
>> Scott Meyers Effective C++ recommendations are to explicitly list all
>>> data members in the initialization list. If you don't list it there,
>>> it's still going to do the constructor, but you may forget that fact.
>>
>> Is that a problem?
>
> Don't know if it's purely a problem - that's just the justification of
> the rule in general as I understand it. But for the most part, we try to
> follow Scott Meyers' suggestions as best as we can. At some point in the
> future (once our code is much cleaner) we'd like to be able to turn on
> the -Weffc++ warning, which will throw a warning/error on not listing
> data members in constructor initialization lists.

What concrete advantages will enabling that warning give us?

Olaf