Code review comment for lp:~kaaveeacs/drizzle/privatized-members-of-NestedJoin

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 04/15/2011 11:22 AM, Olaf van der Spek wrote:
> On Fri, Apr 15, 2011 at 7:59 PM, Monty Taylor <email address hidden> >
> Scott Meyers Effective C++ recommendations are to explicitly list all
>> data members in the initialization list. If you don't list it there,
>> it's still going to do the constructor, but you may forget that fact.
>
> Is that a problem?

Don't know if it's purely a problem - that's just the justification of
the rule in general as I understand it. But for the most part, we try to
follow Scott Meyers' suggestions as best as we can. At some point in the
future (once our code is much cleaner) we'd like to be able to turn on
the -Weffc++ warning, which will throw a warning/error on not listing
data members in constructor initialization lists.

Monty
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk2okQYACgkQ2Jv7/VK1RgGPBwCeO1ZEoT6//+uHrXq5+Kdo/OZ3
oqgAn2iT1Lq2ubssdScGH7/OWbp5gFVw
=lSb7
-----END PGP SIGNATURE-----