Drizzle

Code review comment for lp:~kaaveeacs/drizzle/privatized-members-of-NestedJoin

  1. privatized-members-of-NestedJoin
  2. Merge into development
Revision history for this message
Olaf van der Spek (olafvdspek) wrote :

> List<Item> getSjOuterExprList() const
> void setSjOuterExprList(List<Item> in_sj_outer_expr_list)

Should this be by reference?

Don't forget coding style: first public, than private members.
Also, no need for this:
> join_list(),

review: Needs Fixing

« Back to merge proposal