Code review comment for lp:~jwharshaw/juju-core/fixlogbuild

Revision history for this message
John A Meinel (jameinel) wrote :

There is a little bit of whack-a-mole here, where we have to realize we are adding a new request that exposes a secret and then go filter it out.
I think we can live with it, and it is certainly better than what we have today. I was just wondering if we could have test infrastructure in place that could help us realize when we add something new. (For example, by default the LoggingSuite reads every log message and makes sure that the contents of known passwords are never present in any of the messages.)

Not something you have to change here, just thinking about ways to be more proactive about helping us to not leak secrets.

« Back to merge proposal