We will need tests for this functionality. It's probably best to do them at a relatively high level: ie call the affected APIs, and scan the log for secrets; local testing of just ServerRequest is unlikely to stay a good test as things evolve.
https://codereview.appspot.com/77500045/diff/40001/state/apiserver/apiserver.go File state/apiserver/apiserver.go (right):
https://codereview.appspot.com/77500045/diff/40001/state/apiserver/apiserver.go#newcode132 state/apiserver/apiserver.go:132: // everything. Please register a bug for this and reference it in the comments.
https://codereview.appspot.com/77500045/diff/40001/state/apiserver/apiserver.go#newcode165 state/apiserver/apiserver.go:165: Should we be eliding secrets here as well?
https://codereview.appspot.com/77500045/
« Back to merge proposal
We will need tests for this functionality. It's probably best to do them
at a relatively high level: ie call the affected APIs, and scan the log
for secrets; local testing of just ServerRequest is unlikely to stay a
good test as things evolve.
https:/ /codereview. appspot. com/77500045/ diff/40001/ state/apiserver /apiserver. go /apiserver. go (right):
File state/apiserver
https:/ /codereview. appspot. com/77500045/ diff/40001/ state/apiserver /apiserver. go#newcode132 /apiserver. go:132: // everything.
state/apiserver
Please register a bug for this and reference it in the comments.
https:/ /codereview. appspot. com/77500045/ diff/40001/ state/apiserver /apiserver. go#newcode165 /apiserver. go:165:
state/apiserver
Should we be eliding secrets here as well?
https:/ /codereview. appspot. com/77500045/