Merge lp:~jviares/openobject-addons/extra-6.0 into lp:openobject-addons/extra-6.0

Proposed by Vicente
Status: Merged
Merged at revision: 5703
Proposed branch: lp:~jviares/openobject-addons/extra-6.0
Merge into: lp:openobject-addons/extra-6.0
Diff against target: 13 lines (+3/-0)
1 file modified
account_payment_extension/wizard/wizard_payment_order.py (+3/-0)
To merge this branch: bzr merge lp:~jviares/openobject-addons/extra-6.0
Reviewer Review Type Date Requested Status
Serpent Consulting Services Approve
Review via email: mp+93537@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Vicente (jviares) wrote :

Bug in account_payment_extension/wizard/wizard_payment_order.py
  function search_entries:
  If the amount field is empty, the function doesn't return line ids

Revision history for this message
Serpent Consulting Services (serpent-consulting-services) wrote :

Vicente,

The wizard should be converted now to osv_memory.

The change of code is fine.

Thanks.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'account_payment_extension/wizard/wizard_payment_order.py'
--- account_payment_extension/wizard/wizard_payment_order.py 2011-08-29 17:42:17 +0000
+++ account_payment_extension/wizard/wizard_payment_order.py 2012-02-17 07:33:19 +0000
@@ -110,6 +110,9 @@
110 if abs(line.amount_to_pay) <= amount:110 if abs(line.amount_to_pay) <= amount:
111 amount -= abs(line.amount_to_pay)111 amount -= abs(line.amount_to_pay)
112 selected_ids.append( line.id )112 selected_ids.append( line.id )
113 else:
114 selected_ids = line_ids
115
113 return {116 return {
114 'entries': selected_ids,117 'entries': selected_ids,
115 }118 }