Code review comment for lp:~justinmcp/unity-webapps-gmail/heuristics-update

Revision history for this message
Justin McPherson (justinmcp) wrote :

(for completeness)

webapp-support requires changes in node-validation (which is where
validate.js lives).

On Tue, Jan 7, 2014 at 11:22 AM, Justin McPherson <
<email address hidden>> wrote:

> My fault, I mistakenly believed there was some dependency tracking between
> projects. This should work when some changes to webapps-application go
> through (webapp-support).
>
>
>
>
> On Tue, Jan 7, 2014 at 11:06 AM, Robert Bruce Park <
> <email address hidden>> wrote:
>
>> Your diff introduces '@require validate.js', which causes the jslint
>> checker to fail because it cannot find validate.js in the userscripts
>> directory. What is this file and where did you get it from? The jenkins
>> failure can most easily be resolved by not requiring validate.js, assuming
>> that it can be easily removed from the code...
>> --
>>
>> https://code.launchpad.net/~justinmcp/unity-webapps-gmail/heuristics-update/+merge/199409
>> You are the owner of lp:~justinmcp/unity-webapps-gmail/heuristics-update.
>>
>
>

« Back to merge proposal