Code review comment for lp:~justin-fathomdb/nova/termie-bot

Revision history for this message
justinsb (justin-fathomdb) wrote :

termie: Sorry missed one of your review points. I don't think I really understand this one?

> - i'd put the CHECKER stuff at the bottom of the file if it needs to be built after stuff. Alternatively you can make a small decorator for the class that automatically adds the class and define the CHECKER global at the top

I though Python defined things top-to-bottom, so I think CHECKER_BASE_CLASSES does work. Is your concern that the position is fragile?

« Back to merge proposal