Code review comment for lp:~justin-fathomdb/nova/termie-bot

Revision history for this message
justinsb (justin-fathomdb) wrote :

>
> Something to discuss at the summit, I guess, since it's clear from
> looking at the Nova code that the HACKING text is interpreted
> (ignored?) differently by different devs.

Absolutely... If pep8 finds a violation, it takes me < 1 minute to fix it.
 With our rules that pep8 doesn't fix, if I have to go through the push /
propose / "needs fixing' review / move to WIP / fix / push / comment / move
to 'Needs Review' process, it probably takes 10 minutes, and that's ignoring
the reviewers time (unnecessary email to nova-core), and the fact that some
of these violations are likely overlooked. The more we can get into the
automated category, the better in my book - that's what I'm trying to
achieve here.

There's a secondary issue which is that we don't yet agree on all the rules.
 When do we get our PTLs? - hopefully they can just make these decisions by
dictat.

« Back to merge proposal