Code review comment for lp:~justin-fathomdb/nova/termie-bot

Revision history for this message
termie (termie) wrote :

- copyright and license declarations
- i'd put the CHECKER stuff at the bottom of the file if it needs to be built after stuff. Alternatively you can make a small decorator for the class that automatically adds the class and define the CHECKER global at the top
- you need an if __name__ == '__main__': at the bottom so that people can import this without executing it
- should we make the output look more like pylint?

nova/api/openstack/_id_translator.py:24:19: E261 at least two spaces before inline comment

and it also has the description underneath, though that is an easy extension to make after the fact (just add a method that prints the appropriate rule)

- i can imagine some issues with the 'raise' vs 'raise e' check, while it is usually the case we have some explicit cases right now where we need to 'raise e'
- the docstring for RethrowExceptionsCarefully needs some adjustment :p

review: Needs Fixing

« Back to merge proposal