Code review comment for lp:~justin-fathomdb/nova/san

Revision history for this message
Vish Ishaya (vishvananda) wrote :

This looks pretty awesome. It seems like ssh_execute could live in utils.py, since it is likely useful for other components as well.

107 + # TODO(justinsb): store in volume, remerge with generic iSCSI code
108 + host = FLAGS.san_ip

Perhaps we should have an extra field for ip for all of the iscsi drivers. That way the host name doesn't have to be resolvable from the compute host, and we can git rid of the ugly --iscsi_ip_prefix flag. I'm ok with this happening in another patch though.

The long list of commented setup commands should be moved into the docstring or perhaps fleshed out and moved into docs/

review: Needs Fixing

« Back to merge proposal