Code review comment for lp:~justin-fathomdb/nova/justinsb-hpsan2
Revision history for this message
| FUJITA Tomonori (fujita-tomonori-deactivatedaccount) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
I'm still learning how the volume stuff works but here are some comments about iSCSI stuff:
- Avoiding discovery session sounds better. You can directly insert the target info into open-iscsi db and let open-iscsi log in it.
- iSCSI supports the mutual authentication (the initiator can verify the target too) so it might be better to make 'provider_auth' capable to handle it.
- If you will not remove the discovery session, 'provider_auth' needs to handle discovery session CHAP auth too.