Thanks Jay - I don't know what I was thinking (or if I was thinking). But it does show that this code is error prone if "someone" isn't thinking :-)
I revised the code; I'm not the world's biggest fan of this approach though, so I also coded up a helper function that may make this cleaner, but (as you suggested on IRC) I've made it a separate patch: http://bazaar.launchpad.net/~justin-fathomdb/nova/mini-xpath/revision/702
« Back to merge proposal
Thanks Jay - I don't know what I was thinking (or if I was thinking). But it does show that this code is error prone if "someone" isn't thinking :-)
I revised the code; I'm not the world's biggest fan of this approach though, so I also coded up a helper function that may make this cleaner, but (as you suggested on IRC) I've made it a separate patch: bazaar. launchpad. net/~justin- fathomdb/ nova/mini- xpath/revision/ 702
http://