Code review comment for lp:~justin-fathomdb/nova/bug740576

Revision history for this message
Brian Waldon (bcwaldon) wrote :

> Thanks Brian. I feel 'common' is already there, so I'm leaning towards
> sticking with what we've got. Don't know how others feel?

The other issue is that there is already 'wsgi' related code in __init__.py, so if anything, OpenstackController should live there.

> The default in get_default_xmlns is because it won't be applied if a
> namespace is applied in some other way. For example, I suspect we'll come
> across a need to explicitly specify namespaces for some responses, for
> example if we need to mix namespaces in the same response.

Okay. I missed that in the code.

« Back to merge proposal