Code review comment for lp:~justin-fathomdb/nova/bug724623

Hi Jay - this branch is at the end of a long dependency chain, so I didn't
expect anyone to get to it so fast!!

Certainly I could "back-port" the bugfix, but I don't think it's necessarily
a blocker for anyone so I'm not sure it's worth the effort (?)

However, the 'known_bugs' thing is more interesting.... that's my experiment
in whether this approach works for separating out bugs (as I find them) from
the bug fixes. In this case, I found a random bug while I was writing the
test case: "In the OS API, when creating a server, the metadata is not
returned". I wanted the test case to have the logic, but equally I can't
actually test it until the bug is fixed. I'm not sure it's a high priority
bug at the moment (it's more of a TODO than a bug!) Can you think of a
better approach? Do I dare open this up to mailing list?

I am guilty of putting print statements in my tests - must remember not to
do that!!

On Thu, Feb 24, 2011 at 6:07 PM, Jay Pipes <email address hidden> wrote:

> Review: Disapprove
> I'm not a fan of the known_bugs.py file in the prerequsite branch. Would it
> be possible to just fix the bug and propose that for merging instead of
> having that large pre-req branch? Also, you've got print statements in the
> test case below..
> --
> https://code.launchpad.net/~justin-fathomdb/nova/bug724623/+merge/51227
> You are the owner of lp:~justin-fathomdb/nova/bug724623.
>