Merge lp:~justin-fathomdb/charms/precise/kibana/update-version into lp:charms/kibana

Proposed by justinsb
Status: Merged
Merged at revision: 8
Proposed branch: lp:~justin-fathomdb/charms/precise/kibana/update-version
Merge into: lp:charms/kibana
Diff against target: 168 lines (+53/-45)
4 files modified
config.yaml (+3/-3)
files/charm/config.js (+42/-21)
files/charm/kibana-service.conf (+0/-21)
files/charm/nginx.conf (+8/-0)
To merge this branch: bzr merge lp:~justin-fathomdb/charms/precise/kibana/update-version
Reviewer Review Type Date Requested Status
Marco Ceppi (community) Approve
Review via email: mp+215699@code.launchpad.net

Description of the change

Update to latest kibana (3.0.0-milestone -> 3.0.0)

To post a comment you must log in.
Revision history for this message
Marco Ceppi (marcoceppi) wrote :

Hi Justin, thank you so much for this change! We really appreciate the work in making these charms up today. I noticed you removed the upstart script from this, is there an upstart/init script that comes packaged now with the latest kibana?

Going through the charm I don't see it being used, and it's just exposed via nginx. This LGTM otherwise.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'config.yaml'
--- config.yaml 2013-11-26 09:37:56 +0000
+++ config.yaml 2014-04-14 16:02:25 +0000
@@ -1,13 +1,13 @@
1options:1options:
2 kibana_source:2 kibana_source:
3 type: string3 type: string
4 default: 'https://download.elasticsearch.org/kibana/kibana/kibana-3.0.0milestone4.tar.gz'4 default: 'https://download.elasticsearch.org/kibana/kibana/kibana-3.0.0.tar.gz'
5 description: URL to download the source for kibana5 description: URL to download the source for kibana
6 kibana_source_unpack_directory:6 kibana_source_unpack_directory:
7 type: string7 type: string
8 default: 'kibana-3.0.0milestone4'8 default: 'kibana-3.0.0'
9 description: the name of the directory the tar.gz will unpack to9 description: the name of the directory the tar.gz will unpack to
10 kibana_source_checksum:10 kibana_source_checksum:
11 type: string11 type: string
12 default: '3ee5416c8a61fa95ba9280631a66997e'12 default: 'cef6dc8061c8800ddc5eb2725b9220c0'
13 description: the md5sum of the kibana_source13 description: the md5sum of the kibana_source
1414
=== modified file 'files/charm/config.js'
--- files/charm/config.js 2013-09-29 21:58:50 +0000
+++ files/charm/config.js 2014-04-14 16:02:25 +0000
@@ -1,54 +1,75 @@
1/**1/** @scratch /configuration/config.js/1
2 * These is the app's configuration, If you need to configure2 *
3 * the default dashboard, please see dashboards/default3 * == Configuration
4 * config.js is where you will find the core Kibana configuration. This file contains parameter that
5 * must be set before kibana is run for the first time.
4 */6 */
5define(['settings'],7define(['settings'],
6function (Settings) {8function (Settings) {
7 9
810
11 /** @scratch /configuration/config.js/2
12 *
13 * === Parameters
14 */
9 return new Settings({15 return new Settings({
1016
11 /**17 /** @scratch /configuration/config.js/5
12 * URL to your elasticsearch server. You almost certainly don't18 *
13 * want 'http://localhost:9200' here. Even if Kibana and ES are on19 * ==== elasticsearch
14 * the same host20 *
15 *21 * The URL to your elasticsearch server. You almost certainly don't
16 * By default this will attempt to reach ES at the same host you have22 * want +http://localhost:9200+ here. Even if Kibana and Elasticsearch are on
17 * elasticsearch installed on. You probably want to set it to the FQDN of your23 * the same host. By default this will attempt to reach ES at the same host you have
24 * kibana installed on. You probably want to set it to the FQDN of your
18 * elasticsearch host25 * elasticsearch host
19 * @type {String}
20 */26 */
21 elasticsearch: "http://"+window.location.hostname,27 elasticsearch: "http://"+window.location.hostname,
2228
23 /**29 /** @scratch /configuration/config.js/5
30 *
31 * ==== default_route
32 *
33 * This is the default landing page when you don't specify a dashboard to load. You can specify
34 * files, scripts or saved dashboards here. For example, if you had saved a dashboard called
35 * `WebLogs' to elasticsearch you might use:
36 *
37 * default_route: '/dashboard/elasticsearch/WebLogs',
38 */
39 default_route : '/dashboard/file/default.json',
40
41 /** @scratch /configuration/config.js/5
42 *
43 * ==== kibana-int
44 *
24 * The default ES index to use for storing Kibana specific object45 * The default ES index to use for storing Kibana specific object
25 * such as stored dashboards46 * such as stored dashboards
26 * @type {String}
27 */47 */
28 kibana_index: "kibana-int",48 kibana_index: "kibana-int",
2949
30 /**50 /** @scratch /configuration/config.js/5
31 * Panel modules available. Panels will only be loaded when they are defined in the51 *
52 * ==== panel_name
53 *
54 * An array of panel modules available. Panels will only be loaded when they are defined in the
32 * dashboard, but this list is used in the "add panel" interface.55 * dashboard, but this list is used in the "add panel" interface.
33 * @type {Array}
34 */56 */
35 panel_names: [57 panel_names: [
36 'histogram',58 'histogram',
37 'map',59 'map',
38 'pie',60 'goal',
39 'table',61 'table',
40 'filtering',62 'filtering',
41 'timepicker',63 'timepicker',
42 'text',64 'text',
43 'fields',
44 'hits',65 'hits',
45 'dashcontrol',
46 'column',66 'column',
47 'derivequeries',
48 'trends',67 'trends',
49 'bettermap',68 'bettermap',
50 'query',69 'query',
51 'terms'70 'terms',
71 'stats',
72 'sparklines'
52 ]73 ]
53 });74 });
54});75});
55\ No newline at end of file76\ No newline at end of file
5677
=== removed file 'files/charm/kibana-service.conf'
--- files/charm/kibana-service.conf 2012-11-06 04:38:09 +0000
+++ files/charm/kibana-service.conf 1970-01-01 00:00:00 +0000
@@ -1,21 +0,0 @@
1#!/usr/bin/bash
2
3# kibana service
4#
5
6description "kibana service"
7
8start on virtual-filesystems
9stop on runlevel [06]
10
11respawn
12respawn limit 5 30
13env HOME=/opt/kibana
14chdir /opt/kibana
15setuid kibana
16setgid kibana
17console log
18
19script
20 ruby /opt/kibana/kibana.rb
21end script
22\ No newline at end of file0\ No newline at end of file
231
=== modified file 'files/charm/nginx.conf'
--- files/charm/nginx.conf 2013-11-26 09:44:11 +0000
+++ files/charm/nginx.conf 2014-04-14 16:02:25 +0000
@@ -13,6 +13,14 @@
13 proxy_pass http://es_cluster;13 proxy_pass http://es_cluster;
14 proxy_read_timeout 90;14 proxy_read_timeout 90;
15 }15 }
16 location ~ ^/.*/_aliases$ {
17 proxy_pass http://es_cluster;
18 proxy_read_timeout 90;
19 }
20 location ~ ^/_nodes$ {
21 proxy_pass http://es_cluster;
22 proxy_read_timeout 90;
23 }
16 location ~ ^/.*/_search$ {24 location ~ ^/.*/_search$ {
17 proxy_pass http://es_cluster;25 proxy_pass http://es_cluster;
18 proxy_read_timeout 90;26 proxy_read_timeout 90;

Subscribers

People subscribed via source and target branches

to all changes: