Code review comment for lp:~julien-spautz/switchboard-plug-keyboard/custom-shortcuts
Revision history for this message
| Raphael Isemann (teemperor) wrote | # |
review:
Needs Fixing
(code style, functionality)
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
As Daniel said, you shouln't need to relog/reboot for the keybindings to take effect, so just set "org.gnome.
Interestingly on my system if i do this noise seems to loose the binding to the next/previous keys on my keyboard until i restart noise. But i think that's rather a bug in noise itself?
Otherwise:
* Commented-out code in line 780-781.
* Line 417: tbar = new Gtk.Toolbar(); <- needs a blank before the bracket